<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126732/">https://git.reviewboard.kde.org/r/126732/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 13th, 2016, 2:36 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126732/diff/1/?file=430526#file430526line1" style="color: black; font-weight: bold; text-decoration: underline;">plymouth/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">find_package</span><span class="p">(</span><span class="s">Plymouth</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What about systems without plymouth?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure if it's a good idea to make this a mandatory dependency.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">then it won't get installed
it's not mandatory, it's optional on plymouth being installed</p></pre>
<br />
<p>- Jonathan</p>
<br />
<p>On January 13th, 2016, 2:27 p.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Jan. 13, 2016, 2:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">a plymouth theme for breeze</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">based on kubuntu theme, it's one image with a fading in and out glow
also a 16 bit fallback which is just the static k logo
some cmake to look for the current plymouth theme diretory which could do with testing on other distros
it doesn't try to set it as default theme or run update-initramfs, I think that can only be done by packagers
suggestions for artwork welcome but changing the functionality (fade in and out glow) is not something I have the knowledge or time for
I've not included a text fallback theme, the plymouth text theme seems very limited in functionality and the ubuntu-text theme is presumably distro specific</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">http://weegie.edinburghlinux.co.uk/~jr/tmp/out-3.ogv</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">installed this
set default.plymouth link to point to breeze.plymouth
install plymouth-x11
sudo plymouthd --debug --tty=<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">tty</code> --no-daemon
sudo plymouth show-splash
pretty K blinks</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(cdcc46e)</span></li>
<li>cmake/FindPlymouth.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plymouth/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plymouth/breeze/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>plymouth/breeze/breeze.grub <span style="color: grey">(PRE-CREATION)</span></li>
<li>plymouth/breeze/breeze.plymouth.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>plymouth/breeze/breeze.script <span style="color: grey">(PRE-CREATION)</span></li>
<li>plymouth/breeze/images/16bit/dot.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plymouth/breeze/images/16bit/logo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plymouth/breeze/images/16bit/progress-rect.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plymouth/breeze/images/16bit/text-input.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plymouth/breeze/images/dot.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plymouth/breeze/images/logo-glow.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plymouth/breeze/images/logo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plymouth/breeze/images/source.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>plymouth/breeze/images/text-input.png <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126732/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>