<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126688/">https://git.reviewboard.kde.org/r/126688/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Januar 11th, 2016, 8:12 nachm. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Someone suggested to style it like this: https://i.imgur.com/nPVhWr9.png</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">While I'm not a huge fan of that excessive green background I agree that perhaps the message should be more prominently displayed, ie. moving back to showing the icon next to the message and maybe adding a faint highlight behind the item.</p></pre>
</blockquote>
<p>On Januar 11th, 2016, 8:20 nachm. UTC, <b>Heiko Tietze</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Better than coloring or higlighting parts of the UI you improve positioning and spacing of controls. That means in this case to indent the device information.</p></pre>
</blockquote>
<p>On Januar 11th, 2016, 8:25 nachm. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Indent what? where?</p></pre>
</blockquote>
<p>On Januar 12th, 2016, 1:17 nachm. UTC, <b>Heiko Tietze</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry, I was completely wrong. The term 'style' put me to the wrong track, but actually you wanted to indicate the selection. Well done.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I now made it so the selection rectangle shows up behind the device that shows a message and slowly disappears (3s), I think that works nicely.</p></pre>
<br />
<p>- Kai Uwe</p>
<br />
<p>On Januar 11th, 2016, 4:19 nachm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 11, 2016, 4:19 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Instead of showing a detached status bar with the device name, show the message below the device.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When removing a device, device notifier will pop up and a "You can now safely remove this device" message will show up; after 5 seconds the message and the device will disappear. When trying to unmount a device and it fails, device notifier will show up with an error message that will stay there until device notifier is closed or another message appears.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This review consists of two patches: one for fixing the device notifications engine's wording (I'm open to better verbalizations) and one for the device notifier</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There a still a couple of glitches:
- the layout doesn't properly reset at times (eg. the delegate height doesn't update) or fails to show certain items (also looks like a Qt bug)
- sometimes the delegates suddenly overlap each other beacuse the section thing gets confused when the one item is already gone in the model (looks like a Qt bug)
- the "no devices" heading doesn't know that there's still a pseudo-device there
- it cannot actually highlight the device that was safely removed (it's no longer part of the model and thus has no index), we could do a hack for this though
- the message doesn't disappear reliably or spontaneously re-appears
- depending on your screen dpi you sometimes get a black and white Info icon but the error thing is always red, there's a smaller variant for the former but not the latter apparently, also it seems we lack a proper "task done" icon, Oxygen had one</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/devicenotifier/package/contents/ui/DeviceItem.qml <span style="color: grey">(a410e25)</span></li>
<li>applets/devicenotifier/package/contents/ui/FullRepresentation.qml <span style="color: grey">(9e9aa25)</span></li>
<li>applets/devicenotifier/package/contents/ui/StatusBar.qml <span style="color: grey">(ba827c3)</span></li>
<li>applets/devicenotifier/package/contents/ui/devicenotifier.qml <span style="color: grey">(29cdaca)</span></li>
<li>dataengines/devicenotifications/ksolidnotify.h <span style="color: grey">(fac8cc1)</span></li>
<li>dataengines/devicenotifications/ksolidnotify.cpp <span style="color: grey">(3935ba3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126688/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png">Failed to mount</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png">Safely remove</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png">Emblem icon</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png">Emblem-error</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png">emblem-information</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>