<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126672/">https://git.reviewboard.kde.org/r/126672/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 11th, 2016, 1:38 p.m. CET, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126672/diff/1/?file=429035#file429035line215" style="color: black; font-weight: bold; text-decoration: underline;">autotests/coronatest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void CoronaTest::restore()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">215</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">for</span> <span class="p">(</span><span class="n">Plasma</span><span class="o">::</span><span class="n">Containment</span> <span class="o">*</span><span class="nl">cont</span><span class="hl"> </span><span class="p"><span class="hl">:</span></span> <span class="n">m_corona</span><span class="o">-></span><span class="n">containments</span><span class="p">())</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">215</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">for<span class="hl">each</span></span> <span class="p">(</span><span class="n">Plasma</span><span class="o">::</span><span class="n">Containment</span> <span class="o">*</span><span class="n">cont</span><span class="p"><span class="hl">,</span></span> <span class="n">m_corona</span><span class="o">-></span><span class="n">containments</span><span class="p">())</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do we really not want the C++11 for here? If we don't, I'd prefer Q_FOREACH as replacement, the Q_ macros seem safer in the long run.</p></pre>
</blockquote>
<p>On January 11th, 2016, 2:02 p.m. CET, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It also detaches.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">http://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/</p></pre>
</blockquote>
<p>On January 11th, 2016, 2:06 p.m. CET, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">but wouldn't with for (const Plasma::Containment *cont : m_corona->containments()) {
... right? Would IMO be better, since it's explicit that way.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(Thanks for the other explanations, Aleix!)</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It still would, this const only affects the pointer, but not the container.</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On January 8th, 2016, 2:34 a.m. CET, Sergey Popov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez.</div>
<div>By Sergey Popov.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2016, 2:34 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix almost all the Clazy warnings in plasma-framework.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Related GCI-2015 task: <a href="https://codein.withgoogle.com/tasks/6272625345036288/" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">https://codein.withgoogle.com/tasks/6272625345036288/</a></p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tests passed</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/coronatest.cpp <span style="color: grey">(378a4b7)</span></li>
<li>autotests/dialogqmltest.cpp <span style="color: grey">(618e64d)</span></li>
<li>autotests/fallbackpackagetest.cpp <span style="color: grey">(91bc6e9)</span></li>
<li>autotests/packagestructuretest.cpp <span style="color: grey">(67cdb4f)</span></li>
<li>autotests/pluginloadertest.cpp <span style="color: grey">(868d5f8)</span></li>
<li>autotests/sortfiltermodeltest.cpp <span style="color: grey">(6ee0e35)</span></li>
<li>autotests/storagetest.cpp <span style="color: grey">(8a7dbd0)</span></li>
<li>src/declarativeimports/calendar/calendar.cpp <span style="color: grey">(5515550)</span></li>
<li>src/declarativeimports/calendar/daysmodel.cpp <span style="color: grey">(0f81b5a)</span></li>
<li>src/declarativeimports/core/corebindingsplugin.cpp <span style="color: grey">(adfdc29)</span></li>
<li>src/declarativeimports/core/datamodel.cpp <span style="color: grey">(4449f30)</span></li>
<li>src/declarativeimports/core/datasource.cpp <span style="color: grey">(4fe5dc5)</span></li>
<li>src/declarativeimports/core/tooltip.cpp <span style="color: grey">(a5e223b)</span></li>
<li>src/declarativeimports/core/tooltipdialog.cpp <span style="color: grey">(6c3712e)</span></li>
<li>src/declarativeimports/core/units.cpp <span style="color: grey">(1798727)</span></li>
<li>src/declarativeimports/core/windowthumbnail.cpp <span style="color: grey">(21e655e)</span></li>
<li>src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp <span style="color: grey">(9e924b3)</span></li>
<li>src/declarativeimports/plasmacomponents/qmenuitem.cpp <span style="color: grey">(287e9b3)</span></li>
<li>src/declarativeimports/plasmaextracomponents/plasmaextracomponentsplugin.cpp <span style="color: grey">(1a25f06)</span></li>
<li>src/plasma/applet.cpp <span style="color: grey">(4ce2d28)</span></li>
<li>src/plasma/containment.cpp <span style="color: grey">(0beb196)</span></li>
<li>src/plasma/containmentactions.cpp <span style="color: grey">(f42807f)</span></li>
<li>src/plasma/corona.cpp <span style="color: grey">(bae9244)</span></li>
<li>src/plasma/datacontainer.cpp <span style="color: grey">(396bc6d)</span></li>
<li>src/plasma/dataengine.cpp <span style="color: grey">(dd56807)</span></li>
<li>src/plasma/dataengineconsumer.cpp <span style="color: grey">(7c9b5f9)</span></li>
<li>src/plasma/framesvg.cpp <span style="color: grey">(81187dc)</span></li>
<li>src/plasma/package.cpp <span style="color: grey">(09f36f3)</span></li>
<li>src/plasma/packagestructure.cpp <span style="color: grey">(09ea698)</span></li>
<li>src/plasma/pluginloader.cpp <span style="color: grey">(d7c49f2)</span></li>
<li>src/plasma/private/applet_p.cpp <span style="color: grey">(949c92e)</span></li>
<li>src/plasma/private/associatedapplicationmanager.cpp <span style="color: grey">(e1620e9)</span></li>
<li>src/plasma/private/componentinstaller.cpp <span style="color: grey">(8fbef24)</span></li>
<li>src/plasma/private/containment_p.cpp <span style="color: grey">(09ed2cd)</span></li>
<li>src/plasma/private/dataenginemanager.cpp <span style="color: grey">(7862171)</span></li>
<li>src/plasma/private/packages.cpp <span style="color: grey">(1edd55a)</span></li>
<li>src/plasma/private/service_p.h <span style="color: grey">(8a48487)</span></li>
<li>src/plasma/private/storage.cpp <span style="color: grey">(bc6992e)</span></li>
<li>src/plasma/private/storagethread.cpp <span style="color: grey">(91b490b)</span></li>
<li>src/plasma/private/svg_p.h <span style="color: grey">(1d1000d)</span></li>
<li>src/plasma/private/theme_p.cpp <span style="color: grey">(18419bb)</span></li>
<li>src/plasma/private/timetracker.cpp <span style="color: grey">(cdfe94b)</span></li>
<li>src/plasma/scripting/scriptengine.cpp <span style="color: grey">(b9f43fe)</span></li>
<li>src/plasma/service.cpp <span style="color: grey">(d603cf2)</span></li>
<li>src/plasma/svg.cpp <span style="color: grey">(28abd00)</span></li>
<li>src/plasma/theme.cpp <span style="color: grey">(e9420e6)</span></li>
<li>src/plasmapkg/main.cpp <span style="color: grey">(336b14e)</span></li>
<li>src/plasmapkg/plasmapkg.cpp <span style="color: grey">(4626323)</span></li>
<li>src/plasmaquick/appletquickitem.cpp <span style="color: grey">(ec2ed24)</span></li>
<li>src/plasmaquick/configmodel.cpp <span style="color: grey">(df537c1)</span></li>
<li>src/plasmaquick/configview.cpp <span style="color: grey">(c4ab518)</span></li>
<li>src/plasmaquick/dialog.cpp <span style="color: grey">(8f4ee57)</span></li>
<li>src/plasmaquick/dialogshadows.cpp <span style="color: grey">(db408ae)</span></li>
<li>src/plasmaquick/dialogshadows_p.h <span style="color: grey">(7e17c12)</span></li>
<li>src/plasmaquick/packageurlinterceptor.cpp <span style="color: grey">(5e349d2)</span></li>
<li>src/plasmaquick/private/packages.h <span style="color: grey">(aa08b11)</span></li>
<li>src/plasmaquick/private/packages.cpp <span style="color: grey">(5275848)</span></li>
<li>src/scriptengines/qml/plasmoid/appletinterface.cpp <span style="color: grey">(8e4979a)</span></li>
<li>src/scriptengines/qml/plasmoid/containmentinterface.cpp <span style="color: grey">(31285a2)</span></li>
<li>src/scriptengines/qml/plasmoid/declarativeappletscript.cpp <span style="color: grey">(b15695b)</span></li>
<li>src/scriptengines/qml/plasmoid/wallpaperinterface.cpp <span style="color: grey">(9ecd62b)</span></li>
<li>tests/dpi/main.cpp <span style="color: grey">(6767b2d)</span></li>
<li>tests/kplugins/main.cpp <span style="color: grey">(421e3fb)</span></li>
<li>tests/kplugins/plugintest.h <span style="color: grey">(a99701a)</span></li>
<li>tests/kplugins/plugintest.cpp <span style="color: grey">(3d98dec)</span></li>
<li>tests/testengine/testengine.cpp <span style="color: grey">(76947c3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126672/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>