<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126356/">https://git.reviewboard.kde.org/r/126356/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Januar 10th, 2016, 9:40 vorm. UTC, <b>Heiko Tietze</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not so sure if plasmoids started from desktop and panel have to be equal (if at all than I'd care about the caption). For what reason, familiarity? And the final size in the last picture (clipboardMinimumSize.png) is way too small to suit user's needs. That is here to browse through and read the content. For example 'dd if=/dev/zero of=/dev/s...' thrills only the bravest. The size of clipboard-new.png is okay. The current size for the panel based plasmoid is reasonable and similar to other plasmoids like the notification. And it fits the general visual style of Breeze. But that's only a two cent option. (BTW: I read in several postings that Breeze becomes very breezy with too large marigins and spaces.) Whether </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What I rather would expect is that a desktop plugin shows the list permanently and has means for resizing. Actually what is shown in the last screenshot but with a better default size. Took me some time to figure out how to achieve this (was aware of the option only because of the screenshot): One has to long click the icon! And there is no way back.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">tl;dr: (sorry for all my considerations; writing down all thoughts while testing is somewhat verbose)</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">same height is okay but not really necessary</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">default size should be large enough to read the labels </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">users should be able to minimize as much as possible, so yes to the patch if it's not the default</li>
</ul></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">thanks for the feedback. all my resize stuff is for the minimum size and as Heiko recommand the minimum size should be as minimized as possible. default size would be good but at most plasmoids not available and not part of this task.</p></pre>
<br />
<p>- andreas</p>
<br />
<p>On Januar 9th, 2016, 9:54 nachm. UTC, andreas kainz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Heiko Tietze.</div>
<div>By andreas kainz.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2016, 9:54 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if you use clipboard on the desktop the minimum window height is heigher than you use clipboard from the panel (drop down window). As the user can define the width and height for the desktop plasmoid the minimum allowed height should be at least the same than the drop down window in the panel. so I change the minimumHeig to 16.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/clipboard/contents/ui/clipboard.qml <span style="color: grey">(97230c1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126356/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/cdc4e222-a954-4f92-816f-521f35aab7c7__clipboard-alt_.png">old before with 26 min height</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/50773744-a980-4091-8ef2-7eec516cb597__clipboard-new_.png">new after with 16 min height</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/566b420b-df44-44d4-86b3-b9f2d441aed8__clipboardMinimumSize.png">screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>