<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126630/">https://git.reviewboard.kde.org/r/126630/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126630/diff/1/?file=428477#file428477line46" style="color: black; font-weight: bold; text-decoration: underline;">backends/fake/fake.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">using namespace KScreen;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QLoggingCategory</span><span class="o">::</span><span class="n">setFilterRules</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"kscreen.fake.debug = true"</span><span class="p">));</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Keep this one, fake backend is only for unit-tests.</p></pre>
</div>
</div>
<br />
<p>- Daniel Vrátil</p>
<br />
<p>On January 5th, 2016, 12:27 p.m. CET, Peter Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Solid, Daniel Vrátil, and Sebastian Kügler.</div>
<div>By Peter Wu.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2016, 12:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkscreen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Logging is <a href="https://doc.qt.io/qt-5/qloggingcategory.html#Q_LOGGING_CATEGORY" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">enabled by default</a>, there is no read to use setFilterRules
and <a href="https://doc.qt.io/qt-5/qloggingcategory.html#configuring-categories" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">override</a> any user preferences in QtProject/qtlogging.ini.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested on v5.5.2 (cherry-picked, ignored missing backends/kwayland/waylandbackend.cpp).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Test:</p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Have no kscreen related lines in ~/.config/QtProject/qtlogging.ini</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">killall kscreen_backend_launcher</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Change brightness levels via the keyboard. (Result: <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">RRNotify_OutputProperty</code> messages in <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">journalctl</code>)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Add the following lines to qtlogging.ini:</li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">kscreen.debug=false
kscreen.xrandr.debug=false
kscreen.xcb.helper.debug=false
</pre></div>
</p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">killall kscreen_backend_launcher</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Change brightness levels again. (Result: no log spam!)</li>
</ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>backends/fake/fake.cpp <span style="color: grey">(94586bc)</span></li>
<li>backends/kwayland/waylandbackend.cpp <span style="color: grey">(0700e22)</span></li>
<li>backends/qscreen/qscreenbackend.cpp <span style="color: grey">(56b5a7c)</span></li>
<li>backends/xcbeventlistener.cpp <span style="color: grey">(ee415d7)</span></li>
<li>backends/xrandr/xrandr.cpp <span style="color: grey">(fae1dcc)</span></li>
<li>backends/xrandr1.1/xrandr11.cpp <span style="color: grey">(631bcc9)</span></li>
<li>src/debug_p.cpp <span style="color: grey">(5934417)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126630/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>