<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121010/">https://git.reviewboard.kde.org/r/121010/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 25th, 2015, 12:18 p.m. CET, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ping.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(Is a roundtrip to the X Server that bad for the comparatively rare event of getting a notification?)</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yes, but not only because of the roundtrip, but because it's X11 specific. I don't know how that would work on Wayland - probably not at all.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Furthermore this does not consider the case that we have multiple screens and the notification would be shown on the other screen which is not covered by a fullscreen window.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So at the moment, I don't have an idea, but I think we need a solution which will work on Wayland and considers multiple screens.</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On November 6th, 2014, 12:47 p.m. CET, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, KDE Usability and Martin Gräßlin.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2014, 12:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch improves fullscreen handling in notifications.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The type of the NotificationPopup is changed to Dialog.Notification because that's what it's for, I think there's been a bit of a miscommunication about that (I think there needs to be another layer for the OSD because that one should be above all..).
The Notification type keeps the window above (sorta fixing Bug 338946 because the close button now works as expected now) everything but not a fullscreen window if it's active. This patch checks when a notification arrives whether the active window is fullscreen (concealing the notification) and adds it to the history. To indicate that you missed notifications while you were fullscreen, the icon glows blue (until you interact with a notification or open the plasmoid).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fullscreened my IDE, "sleep 2; knotificationdbustest", waited, unfullscreened, icon was blue and the history a few notifications in it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/notifications/package/contents/ui/NotificationIcon.qml <span style="color: grey">(1449c19)</span></li>
<li>applets/notifications/package/contents/ui/NotificationPopup.qml <span style="color: grey">(212f1e6)</span></li>
<li>applets/notifications/package/contents/ui/Notifications.qml <span style="color: grey">(acdccdd)</span></li>
<li>applets/notifications/package/contents/ui/main.qml <span style="color: grey">(3c2fa13)</span></li>
<li>applets/notifications/plugin/notificationshelper.h <span style="color: grey">(af8f6fa)</span></li>
<li>applets/notifications/plugin/notificationshelper.cpp <span style="color: grey">(425f0d6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121010/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/11/06/3f2141b2-1452-4e5c-8b00-782c571ad34b__notificationpendingthing.png">Pending notification in tray</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>