<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126475/">https://git.reviewboard.kde.org/r/126475/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, David Edmundson and Martin Gräßlin.</div>
<div>By Eike Hein.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=356938">356938</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PlasmaCore.WindowThumbnail acts as a mini-compositor and redirects windows to paint a thumbnail of them. Hovering a Task Manager button delegate will down the line instanciate some WindowThumbnails for the tooltip, and these stick around when the tooltip is hidden. This causes windows to keep being redirected, e.g. severely breaking game performance after hovering them in the Task Manager (see associated bug).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I initially tried just wiping the thumbnail delegates on the Task Manager side when the tooltip goes hidden, but this breaks UX performance when moving across tasks in the applet because the tooltip delegate's visibility prop cycles between true and false from one ToolTipArea to the next. I'll still be tweaking the Task Manager code to at the very least do this when tooltips are disabled to avoid even instanciating, but in the meantime, making WindowThumbnail more idiot-proof strikes me as a good idea regardless.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/windowthumbnail.cpp <span style="color: grey">(5fc5c5e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126475/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>