<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126301/">https://git.reviewboard.kde.org/r/126301/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126301/diff/1/?file=421557#file421557line45" style="color: black; font-weight: bold; text-decoration: underline;">src/client/protocols/server-decoration.xml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nt"><request</span> <span class="na">name=</span><span class="s">"release"</span> <span class="na">type=</span><span class="s">"destructor"</span><span class="nt">></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">do clients have to explicitly call that with risks of leaks?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126301/diff/1/?file=421557#file421557line57" style="color: black; font-weight: bold; text-decoration: underline;">src/client/protocols/server-decoration.xml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">57</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nt"><event</span> <span class="na">name=</span><span class="s">"mode"</span><span class="nt">></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the use case is that i can request a mode, but the server can ignore it and send me a different mode instead?</p></pre>
</div>
</div>
<br />
<p>- Marco Martin</p>
<br />
<p>On December 10th, 2015, 2:03 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Sebastian Kügler.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Dec. 10, 2015, 2:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwayland
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">[client] Add implementation for ServerSideDecoration
[server] Add implementation for server side decoration protocol
[autotest] Add tests for ServerSideDecoration protocol</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/client/test_wayland_registry.cpp <span style="color: grey">(772da821d634efa1c72d13a7c081994bd78ab7fd)</span></li>
<li>autotests/client/CMakeLists.txt <span style="color: grey">(014b5e0798618394ecf11c8b8cfa796dcf9c37f3)</span></li>
<li>autotests/client/test_server_side_decoration.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/CMakeLists.txt <span style="color: grey">(1d2b5492954e07fc77b2209a123ef8e43e340e8a)</span></li>
<li>src/client/protocols/server-decoration.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/registry.h <span style="color: grey">(c079852a4d96471face2a06795a531abf2e4d8c0)</span></li>
<li>src/client/registry.cpp <span style="color: grey">(71640e184da4699bdc27a993b710b1f761c919d2)</span></li>
<li>src/client/server_decoration.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/server_decoration.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/server/CMakeLists.txt <span style="color: grey">(cd5c7bb1a93a470fd58cb9c6d86068da961addeb)</span></li>
<li>src/server/display.h <span style="color: grey">(154e0f0b4c00375ca7d7f0a980392877fe743f50)</span></li>
<li>src/server/display.cpp <span style="color: grey">(81ea7316e3b77f6db95748339d3dfaa303333d33)</span></li>
<li>src/server/server_decoration_interface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/server/server_decoration_interface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tools/mapping.txt <span style="color: grey">(9dc8204d65092aa86f6ced8ae5a131a2f89018d0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126301/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>