<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125862/">https://git.reviewboard.kde.org/r/125862/</a>
     </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On December 4th, 2015, 7:52 p.m. CET, <b>Martin Klapetek</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I just found out that KHolidays is actually not a framework but part of KDE Applications. Will a dependency like that be ok?</p></pre>
 </blockquote>







</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if it is optional and doesn't introduce a dependency loop I think it's fine.</p></pre>
<br />










<p>- Martin</p>


<br />
<p>On November 18th, 2015, 1:33 a.m. CET, Martin Klapetek wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>


<p style="color: grey;"><i>Updated Nov. 18, 2015, 1:33 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is very simple for now as there is no configuration
yet, so it just takes the default region (your locale)
and shows holidays from that.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Obviously this needs a config to set up which regions
you want to show in there, but this is a start.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Holidays are properly listed in calendar applet.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(4783a78)</span></li>

 <li>plasmacalendarintegration/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasmacalendarintegration/HolidaysConfig.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasmacalendarintegration/holidayeventsplugin.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasmacalendarintegration/holidaysevents.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasmacalendarintegration/holidaysevents.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasmacalendarintegration/qmlhelper/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasmacalendarintegration/qmlhelper/qmldir <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125862/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>