<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126166/">https://git.reviewboard.kde.org/r/126166/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- andreas kainz</p>
<br />
<p>On November 25th, 2015, 1:54 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, andreas kainz and Uri Herrera.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2015, 1:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze-icons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">unfortunately the diff was about 35 megabytes, so was too big for reviewboard little mind ;)
a tarball of the modified icons can be found at http://notmart.org/misc/breeze-icons.tar.bz2
this changes the monochrome breeze icons (other icons are untouched) to use stylesheets instead of hardcoded colors, at least with text color for the black bits, background for the light bits.
This is kinda needed for icons loaded in plasma (even tough some basic icons in the plasma theme systray and actions are still needed, less duplication would be needed)
Will be needed a bit more stringently in plasma mobile, where the plasma theme is used as theme for applications (and probably some effects will be needed like changing icons from black to white on the fly)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This change is not supposed to change the look of any icon anywhere: for desktop applications all of them should look <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">exactly</em> the same as they did (please doublecheck this ;))</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(886ab74)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126166/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>