<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125993/">https://git.reviewboard.kde.org/r/125993/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Ashish Bansal and Bhushan Shah.</div>
<div>By Aditya Dev Sharma.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2015, 4:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Implemented it like the other datasources.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . handleLastFmNewMedia then calls fetchImage for each newMedia in the newMediaList.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">After the image is fetched, gotImage emits the signal mediaUpdated (from mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds 100%.
However the audio scrobbler api doesn't seem to work which I'll fix after this.
Fixed the QThread LastfmImageFetcher Warning.
Apart from it, all the datasources are loaded and media plays as expected.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>datasources/CMakeLists.txt <span style="color: grey">(a7171b7)</span></li>
<li>autotests/lastfmimagefetchertest.cpp <span style="color: grey">(abb3fd6)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(04ba1c3)</span></li>
<li>autotests/lastfmimagefetchertest.h <span style="color: grey">(eb7cb29)</span></li>
<li>datasources/lastfm/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>datasources/lastfm/lastfmimagefetcher.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/CMakeLists.txt <span style="color: grey">(5a13449)</span></li>
<li>libs/mediacenter/lastfmimagefetcher.h <span style="color: grey">(ecff37e)</span></li>
<li>libs/mediacenter/lastfmimagefetcher.cpp <span style="color: grey">(e005077)</span></li>
<li>libs/mediacenter/medialibrary.h <span style="color: grey">(45744c1)</span></li>
<li>libs/mediacenter/pmcmetadatamodel.cpp <span style="color: grey">(2fe6efe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125993/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>