<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126102/">https://git.reviewboard.kde.org/r/126102/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Nov. 18, 2015, 4:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change makes sure that the environment scripts are not sourced
before KWin is started. No user installed scripts are allowed to modify
KWin's environment as that opens an attack vector.
For example any binary plugin loaded into KWin (be it QStyle, QPT plugin,
etc.) is able to become a key logger. If the env variables were allowed
to be sourced before KWin is started a malicious application run as user
(e.g. exploiting browser vulnerability) would be able to install a key
logger. Required steps:
1. install a malicious QStyle plugin somewhere in $HOME
2. place a script in env to adjust variables to load the QStyle plugin
This would be enough to have a key logger on next login.
Given that the startup of KWin must not be affected by any scripts
owned by user prior to startup.
The env scripts are now sourced as first step of startplasma, so
for applications in the session there is no difference.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>startkde/startplasma.cmake <span style="color: grey">(8360a636d3f68c957a15158484360a611cfe3ff8)</span></li>
<li>startkde/startplasmacompositor.cmake <span style="color: grey">(8b5db615142455fd360c66504fc5d5a7754a029c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126102/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>