<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126089/">https://git.reviewboard.kde.org/r/126089/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Overall, good stuff. Some minor comments, and my review hasn't been very thorough.</p></pre>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/126089/file/2551/" style="color: black; font-weight: bold; font-size: 9pt;">snapshot18.png</a>
<p>snapshot18.png</p>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">spacing (also on the right and at the bottom)</p></pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126089/diff/1/?file=417102#file417102line39" style="color: black; font-weight: bold; text-decoration: underline;">themeexplorer/package/contents/ui/ColorButton.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">height:</span> <span class="nx">theme</span><span class="p">.</span><span class="nx">mSize</span><span class="p">(</span><span class="nx">theme</span><span class="p">.</span><span class="nx">defaultFont</span><span class="p">).</span><span class="nx">height</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">gridUnit?</p></pre>
</div>
</div>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On November 16th, 2015, 2:37 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2015, 2:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-sdk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">add a metadata editor functionality that allows to create a theme based upon the default one and edit some of the metadata afterwards</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">add a graphical editor for the color file that has a little preview with fake widgets to give an idea how the colors will look</p>
</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>themeexplorer/package/contents/ui/ColorButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>themeexplorer/package/contents/ui/ColorEditor.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>themeexplorer/package/contents/ui/FormLabel.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>themeexplorer/package/contents/ui/MetadataEditor.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>themeexplorer/package/contents/ui/fakecontrols/Button.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>themeexplorer/package/contents/ui/fakecontrols/CheckBox.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>themeexplorer/package/contents/ui/fakecontrols/LineEdit.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>themeexplorer/package/contents/ui/main.qml <span style="color: grey">(af61c39)</span></li>
<li>themeexplorer/src/CMakeLists.txt <span style="color: grey">(c971784)</span></li>
<li>themeexplorer/src/coloreditor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>themeexplorer/src/coloreditor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>themeexplorer/src/main.cpp <span style="color: grey">(f2ec4a2)</span></li>
<li>themeexplorer/src/themelistmodel.h <span style="color: grey">(3ae6eb4)</span></li>
<li>themeexplorer/src/themelistmodel.cpp <span style="color: grey">(32a6fd4)</span></li>
<li>themeexplorer/src/thememodel.h <span style="color: grey">(18e404d)</span></li>
<li>themeexplorer/src/thememodel.cpp <span style="color: grey">(5366a7e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126089/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/2ec2a6f6-a9db-4527-b3ce-05c9ac4585a2__snapshot18.png">snapshot18.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/3cba4a35-5bf0-485b-a94e-65e6fd07e778__snapshot17.png">snapshot17.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>