<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125991/">https://git.reviewboard.kde.org/r/125991/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 8th, 2015, 3:37 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Showing it always does make sense as long as it affects only a few Plasmoids, yes.
About the undo: I'm wondering if it might make sense - for consistency's sake - to do the undo mechanism similar to undoing the removal of a Plasmoid from the desktop/panel, i.e. via a button in a notification confirming about the completed deinstallation?</p></pre>
</blockquote>
<p>On November 15th, 2015, 2:59 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So you want the thing to be removed from the list immediately when I press delete and then we spawn a notification on the opposite side of the screen? Doesn't sound too usable for me given the widget explorer is always on the left side of the screen.</p></pre>
</blockquote>
<p>On November 16th, 2015, 9:45 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">not so sure it it would work there..
maybe just adding an overlay to the applet thumbnail a "deleted" with and undo button and actually uninstall all of them when the widget expolorer gets closed (again, not sure is a good idea)</p></pre>
</blockquote>
<p>On November 16th, 2015, 10:07 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So basically like it is now, except I add an overlay saying "Uninstalled" with a more prominent Undo button.</p></pre>
</blockquote>
<p>On November 16th, 2015, 7:44 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The reason why I suggested doing it like we do with Plasmoids is simply consistency. The more knowledge users can transfer from one area to another, the better. Undoing an uninstall should not be such a common thing (unless you are a user who constantly clicks the wrong things), so I believe that consistency is more important than comfort.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That said, Marco's suggestions makes sense to me as well. It would look similar to the Plasmoid mechanism while keeping in the same place.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The downside I see is that if one clicks uninstall, closes the widget explorer (because one thinks the task is complete) and in the next split second realized "Oh fuck, that was the wrong one!", it's too late. With a notification, one has much more time to undo the action.</p></pre>
</blockquote>
<p>On November 16th, 2015, 8:13 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ideally there should be a timeout, just like with the notification, before it disappears. Like for 1 minute, it will stay there and then disappear altogether.</p></pre>
</blockquote>
<p>On November 16th, 2015, 8:22 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So re-opening the widget explorer during that timeout would still shout the undo button?
That would work.</p></pre>
</blockquote>
<p>On November 16th, 2015, 8:28 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If I stored the pending deletions in the Desktop.qml rather than the WidgetExplorer.qml (not sure I want to do that though) they would survive the widget explorer closing. I would not do separate timers (to not complicate things), though, but always 1 minute after the last widget I deleted (and restart the timer if you delete another one in the meantime) it would remove all pending ones.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I believe surviving the widget explorer closing would be important so that a single click would not delete them permanently.
The proposed timer logic totally makes sense to me.</p></pre>
<br />
<p>- Thomas</p>
<br />
<p>On November 8th, 2015, 12:23 a.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Nov. 8, 2015, 12:23 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The no longer enabled tooltip also contained the uninstall button. This restores the uninstall functionality similar to the wallpaper dialog.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">User-installed applets get an uninstall button. I chose to always show it rather than on hover since only a few applets are likely to be uninstallable and I don't want to play the guessing-game, perhaps we should introduce a filter for "User-installed applets" similar to the (less useful) "running" ones. Clicking the button will queue the uninstallation which can be cancelled anytime the dialog is still opened. As soon as the dialog closes, the actual uninstall is executed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Multiple applets can be enqueued simultaneously.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Installed plasmoid through drag and drop, uninstalled after fixing an uninstall bug (Review 125990)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The tooltip says "Undo uninstall". I just noticed I should probably fade the applet name too.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktoppackage/contents/explorer/AppletDelegate.qml <span style="color: grey">(5a81b91)</span></li>
<li>desktoppackage/contents/explorer/WidgetExplorer.qml <span style="color: grey">(af27229)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125991/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png">Uninstall before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png">Undo uninstall</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>