<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126027/">https://git.reviewboard.kde.org/r/126027/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 11th, 2015, 2:38 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126027/diff/1/?file=416142#file416142line83" style="color: black; font-weight: bold; text-decoration: underline;">applets/kicker/plugin/computermodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">83</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="nb">false</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">return QSortFilterProxyModel::lessThan()</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I dont't think you can rely on it following the source model's order.
I had a look at qsortfilterproxy model code; sort() uses stable sort so it implicitly will, but the insert methods don't seem to.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also without this your explicit setSortRole will do nothing.</p></pre>
</blockquote>
<p>On November 11th, 2015, 3:27 p.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I flipped back and forth on this because I'd prefer retaining the order and this at least makes sure the initial load follows user places order, but it's true it's not very good. I'll go with alphabetic for now and address sorting further after this is merged.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if you want to retain the order, you could check the source row in the final lessThan.</p></pre>
<br />
<p>- David</p>
<br />
<p>On November 11th, 2015, 3:28 p.m. UTC, Eike Hein wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Ivan Čukić.</div>
<div>By Eike Hein.</div>
<p style="color: grey;"><i>Updated Nov. 11, 2015, 3:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a roll-up of the various Kicker backend and ultimately Kickoff changes needed to obsolete Kickoff's old backend in favor of Kicker's. It raises Kickoff to Kicker's feature level (much more fleshed-out context menus with many additional features, pervasive favoriting, etc.) along with addressing numerous Kickoff bugs (e.g. sorting on the Computer page) and removing some cruft.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Migration from kickoffrc is done using a script and supports both favorites and ISV-customized system apps for the Computer page.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I suggest using the hein/kickeroff branch for review instead, as things are nicely split out into separate commits there.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kicker/CMakeLists.txt <span style="color: grey">(bdb6419)</span></li>
<li>applets/kicker/package/contents/code/tools.js <span style="color: grey">(ccfa2c5)</span></li>
<li>applets/kicker/package/contents/ui/DashboardRepresentation.qml <span style="color: grey">(9cc316b)</span></li>
<li>applets/kicker/package/contents/ui/ItemGridDelegate.qml <span style="color: grey">(78cd40b)</span></li>
<li>applets/kicker/package/contents/ui/main.qml <span style="color: grey">(4634630)</span></li>
<li>applets/kicker/plugin/abstractentry.h <span style="color: grey">(e09b3cf)</span></li>
<li>applets/kicker/plugin/abstractentry.cpp <span style="color: grey">(846a548)</span></li>
<li>applets/kicker/plugin/abstractmodel.h <span style="color: grey">(142de27)</span></li>
<li>applets/kicker/plugin/abstractmodel.cpp <span style="color: grey">(18eed03)</span></li>
<li>applets/kicker/plugin/actionlist.h <span style="color: grey">(4aaa1d5)</span></li>
<li>applets/kicker/plugin/appentry.h <span style="color: grey">(3d0b1bd)</span></li>
<li>applets/kicker/plugin/appentry.cpp <span style="color: grey">(34bab3d)</span></li>
<li>applets/kicker/plugin/appsmodel.h <span style="color: grey">(3cd0577)</span></li>
<li>applets/kicker/plugin/appsmodel.cpp <span style="color: grey">(821ae88)</span></li>
<li>applets/kicker/plugin/computermodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/kicker/plugin/computermodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/kicker/plugin/favoritesmodel.cpp <span style="color: grey">(4931a16)</span></li>
<li>applets/kicker/plugin/fileentry.h <span style="color: grey">(cd4e54a)</span></li>
<li>applets/kicker/plugin/fileentry.cpp <span style="color: grey">(693816d)</span></li>
<li>applets/kicker/plugin/kickerplugin.cpp <span style="color: grey">(d31043a)</span></li>
<li>applets/kicker/plugin/recentappsmodel.h <span style="color: grey">(6ee55c1)</span></li>
<li>applets/kicker/plugin/recentappsmodel.cpp <span style="color: grey">(3d167c5)</span></li>
<li>applets/kicker/plugin/recentdocsmodel.h <span style="color: grey">(df12d1b)</span></li>
<li>applets/kicker/plugin/recentdocsmodel.cpp <span style="color: grey">(ae7306f)</span></li>
<li>applets/kicker/plugin/recentusagemodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/kicker/plugin/recentusagemodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/kicker/plugin/rootmodel.h <span style="color: grey">(5acdb8e)</span></li>
<li>applets/kicker/plugin/rootmodel.cpp <span style="color: grey">(fde16fd)</span></li>
<li>applets/kicker/plugin/runnermatchesmodel.cpp <span style="color: grey">(d375fd7)</span></li>
<li>applets/kicker/plugin/runnermodel.h <span style="color: grey">(d827e6d)</span></li>
<li>applets/kicker/plugin/runnermodel.cpp <span style="color: grey">(4eb6ccc)</span></li>
<li>applets/kicker/plugin/systementry.h <span style="color: grey">(df0712b)</span></li>
<li>applets/kicker/plugin/systementry.cpp <span style="color: grey">(ec527da)</span></li>
<li>applets/kicker/plugin/systemmodel.h <span style="color: grey">(1b3eab7)</span></li>
<li>applets/kicker/plugin/systemmodel.cpp <span style="color: grey">(ef02892)</span></li>
<li>applets/kickoff/CMakeLists.txt <span style="color: grey">(339316d)</span></li>
<li>applets/kickoff/STATUS-TODO <span style="color: grey">(f837793)</span></li>
<li>applets/kickoff/core/applicationmodel.h <span style="color: grey">(cc28656)</span></li>
<li>applets/kickoff/core/applicationmodel.cpp <span style="color: grey">(a292130)</span></li>
<li>applets/kickoff/core/favoritesmodel.h <span style="color: grey">(7a5f225)</span></li>
<li>applets/kickoff/core/favoritesmodel.cpp <span style="color: grey">(be47347)</span></li>
<li>applets/kickoff/core/itemhandlers.h <span style="color: grey">(8f05490)</span></li>
<li>applets/kickoff/core/itemhandlers.cpp <span style="color: grey">(d0cd423)</span></li>
<li>applets/kickoff/core/kickoffabstractmodel.h <span style="color: grey">(be5ce21)</span></li>
<li>applets/kickoff/core/kickoffabstractmodel.cpp <span style="color: grey">(43afb1b)</span></li>
<li>applets/kickoff/core/kickoffmodel.h <span style="color: grey">(dd91f9b)</span></li>
<li>applets/kickoff/core/kickoffmodel.cpp <span style="color: grey">(fd5bb62)</span></li>
<li>applets/kickoff/core/kickoffplugin.h <span style="color: grey">(de839b3)</span></li>
<li>applets/kickoff/core/kickoffplugin.cpp <span style="color: grey">(ef6cbdd)</span></li>
<li>applets/kickoff/core/kickoffproxymodel.h <span style="color: grey">(f1af640)</span></li>
<li>applets/kickoff/core/kickoffproxymodel.cpp <span style="color: grey">(8c58d2b)</span></li>
<li>applets/kickoff/core/krunnermodel.h <span style="color: grey">(3916829)</span></li>
<li>applets/kickoff/core/krunnermodel.cpp <span style="color: grey">(f8c031b)</span></li>
<li>applets/kickoff/core/leavemodel.h <span style="color: grey">(f95a271)</span></li>
<li>applets/kickoff/core/leavemodel.cpp <span style="color: grey">(154eb1c)</span></li>
<li>applets/kickoff/core/models.h <span style="color: grey">(30e80be)</span></li>
<li>applets/kickoff/core/models.cpp <span style="color: grey">(a63d363)</span></li>
<li>applets/kickoff/core/org.kde.kickoff.recent.xml <span style="color: grey">(d013f62)</span></li>
<li>applets/kickoff/core/org.kde.kickoff.xml <span style="color: grey">(b0f5d09)</span></li>
<li>applets/kickoff/core/processrunner.h <span style="color: grey">(5d836eb)</span></li>
<li>applets/kickoff/core/processrunner.cpp <span style="color: grey">(6572386)</span></li>
<li>applets/kickoff/core/qmldir <span style="color: grey">(d454d1b)</span></li>
<li>applets/kickoff/core/recentapplications.h <span style="color: grey">(b73d526)</span></li>
<li>applets/kickoff/core/recentapplications.cpp <span style="color: grey">(2dd6781)</span></li>
<li>applets/kickoff/core/recentlyusedmodel.h <span style="color: grey">(2530fb4)</span></li>
<li>applets/kickoff/core/recentlyusedmodel.cpp <span style="color: grey">(afeed23)</span></li>
<li>applets/kickoff/core/systemmodel.h <span style="color: grey">(5da49ad)</span></li>
<li>applets/kickoff/core/systemmodel.cpp <span style="color: grey">(461a2ed)</span></li>
<li>applets/kickoff/core/urlitemlauncher.h <span style="color: grey">(05c414d)</span></li>
<li>applets/kickoff/core/urlitemlauncher.cpp <span style="color: grey">(c350680)</span></li>
<li>applets/kickoff/package/contents/code/tools.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/kickoff/package/contents/config/config.qml <span style="color: grey">(fe059b8)</span></li>
<li>applets/kickoff/package/contents/config/main.xml <span style="color: grey">(00dfdf9)</span></li>
<li>applets/kickoff/package/contents/ui/ActionMenu.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/kickoff/package/contents/ui/ApplicationsView.qml <span style="color: grey">(ad5272a)</span></li>
<li>applets/kickoff/package/contents/ui/BaseView.qml <span style="color: grey">(e628614)</span></li>
<li>applets/kickoff/package/contents/ui/Breadcrumb.qml <span style="color: grey">(016cf25)</span></li>
<li>applets/kickoff/package/contents/ui/ComputerView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/kickoff/package/contents/ui/ConfigGeneral.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/kickoff/package/contents/ui/ContextMenu.qml <span style="color: grey">(e8f681e)</span></li>
<li>applets/kickoff/package/contents/ui/FavoritesView.qml <span style="color: grey">(f286592)</span></li>
<li>applets/kickoff/package/contents/ui/Footer.qml <span style="color: grey">(dcc762f)</span></li>
<li>applets/kickoff/package/contents/ui/FullRepresentation.qml <span style="color: grey">(a7559ac)</span></li>
<li>applets/kickoff/package/contents/ui/Kickoff.qml <span style="color: grey">(33b49eb)</span></li>
<li>applets/kickoff/package/contents/ui/KickoffButton.qml <span style="color: grey">(ac1e96a)</span></li>
<li>applets/kickoff/package/contents/ui/KickoffItem.qml <span style="color: grey">(f7038cc)</span></li>
<li>applets/kickoff/package/contents/ui/KickoffLeaveItem.qml <span style="color: grey">(3b06395)</span></li>
<li>applets/kickoff/package/contents/ui/LeaveView.qml <span style="color: grey">(00e758e)</span></li>
<li>applets/kickoff/package/contents/ui/RecentlyUsedView.qml <span style="color: grey">(df25db2)</span></li>
<li>applets/kickoff/package/contents/ui/SearchView.qml <span style="color: grey">(f75a7ec)</span></li>
<li>applets/kickoff/package/contents/ui/SystemView.qml <span style="color: grey">(e0093f0)</span></li>
<li>applets/kickoff/package/contents/ui/configGeneral.qml <span style="color: grey">(d754c34)</span></li>
<li>containments/desktop/package/contents/ui/FolderViewLayer.qml <span style="color: grey">(807cc93)</span></li>
<li>containments/desktop/package/contents/ui/UpButtonItem.qml <span style="color: grey">(83efe73)</span></li>
<li>desktoppackage/contents/updates/obsolete_kickoffrc.js <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126027/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>