<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126016/">https://git.reviewboard.kde.org/r/126016/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 11th, 2015, 7:14 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126016/diff/1/?file=416095#file416095line627" style="color: black; font-weight: bold; text-decoration: underline;">libtaskmanager/taskitem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QUrl TaskItem::launcherUrlFromTask(GroupManager *groupManager, Task *task, Startup *startup)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">627</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">launcherUrl</span> <span class="o">=</span> <span class="n">getServiceLauncherUrl</span><span class="p">(</span><span class="n">task</span><span class="o">-></span><span class="n">pid</span><span class="p">(),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"KCModule"</span><span class="p">),</span> <span class="n">QStringList</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"kdeinit4:"</span><span class="p">)</span> <span class="o"><<</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"[kdeinit]"</span><span class="p">));</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">627</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">launcherUrl</span> <span class="o">=</span> <span class="n">getServiceLauncherUrl</span><span class="p">(</span><span class="n">task</span><span class="o">-></span><span class="n">pid</span><span class="p">(),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"KCModule"</span><span class="p">),</span> <span class="n">QStringList</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"kdeinit4:"</span><span class="p">)</span> <span class="o"><<</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"[kdeinit]"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">don't we have to change to kdeinit5 here?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No. The commandline is /path/used/to/launch/kcmshell5 style. The "kcmshell5 style" portion is eventually matched to the desktop file in getServiceLauncherUrl.</p></pre>
<br />
<p>- Johan</p>
<br />
<p>On November 10th, 2015, 6:54 p.m. UTC, Johan Ouwerkerk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Johan Ouwerkerk.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2015, 6:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Previously the taskmanager library contained a special case logic for windows of KDE-4 KCM modules (only).
These modules were recognised by finding wmClass=Kcmshell4.
This logic is extended to cover kcmshell5 windows as well, meaning that KCMs written for Plasma 5 are properly recognised now.
The net benefit is that these KCMs are displayed in the task manager with their proper KCM program icons.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch can be pulled from the kcmshell5-task-url-fixes branch at: git@github.com:cmacq2/plasma-workspace.git</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built with kdesrc-build, and tested using: <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">plasmawindowed org.kde.plasma.icontasks</code>.
I checked the change works as expected by running <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">which kcmshell5</code> style as well as <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">kcmshell5 style</code>: the icon of the window matches that in system settings (as expected).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libtaskmanager/taskitem.cpp <span style="color: grey">(3b2a4188fc8ed087a331999aee279ecd919c628e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126016/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>