<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126008/">https://git.reviewboard.kde.org/r/126008/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the crash in the tests is exactly the same line of code missing. We need to disable high dpi scaling also in the tests.</p></pre>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On November 9th, 2015, 11:48 p.m. CET, Takahiro Hashimoto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Takahiro Hashimoto.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2015, 11:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Qt::AA_NoHighDpiScaling has been replaced with another HighDpi scale enabler/disabler at Qt 5.6 branch (qt5.git submodule already updated)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://codereview.qt-project.org/#/c/127895/</p>
<h2 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">This case build error with Qt 5.6 branch as following.</h2>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">/home/kenya888/devel/kf5/src/kde/workspace/kwin/main_wayland.cpp: In function 'int main(int, char**)':
/home/kenya888/devel/kf5/src/kde/workspace/kwin/main_wayland.cpp:379:36: error: 'AA_NoHighDpiScaling' is not a member of 'Qt'
QCoreApplication::setAttribute(Qt::AA_NoHighDpiScaling, true);</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch fix this use Qt::AA_DisableHighDpiScaling instead of it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Build succeeded. Some test are failed, I know Martin is working about kwin wayland forcused on Qt 5.4. More investigation for test error is needed by myself. At the moment I'd like to avoid simply build error.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As reference, I'll paste ninja test log. tested with Qt 5.6 branch latest.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kenya888@xps13 ~/devel/kf5/build/kde/workspace/kwin $ cat ~/kwin-test.log
[1/1] Running tests...
Test project /home/kenya888/devel/kf5/build/kde/workspace/kwin
Start 1: kwineffects-windowquadlisttest
1/23 Test #1: kwineffects-windowquadlisttest ... Passed 0.05 sec
Start 2: kwin-testTabBoxClientModel
2/23 Test #2: kwin-testTabBoxClientModel ....... Passed 0.05 sec
Start 3: kwin-testTabBoxHandler
3/23 Test #3: kwin-testTabBoxHandler ........... Passed 0.05 sec
Start 4: kwin-testTabBoxConfig
4/23 Test #4: kwin-testTabBoxConfig ............ Passed 0.00 sec
Start 5: kwin-testDesktopChain
5/23 Test #5: kwin-testDesktopChain ............ Passed 0.01 sec
Start 6: kwin-testScreenPaintData
6/23 Test #6: kwin-testScreenPaintData ......... Passed 0.05 sec
Start 7: kwin-testWindowPaintData
7/23 Test #7: kwin-testWindowPaintData ......... Passed 0.05 sec
Start 8: kwin-testVirtualDesktops
8/23 Test #8: kwin-testVirtualDesktops ......... Passed 0.49 sec
Start 9: kwin-testClientMachine
9/23 Test #9: kwin-testClientMachine ...........<strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Exception: Other 0.26 sec
Start 10: kwin-testXcbWrapper
10/23 Test #10: kwin-testXcbWrapper .............. Passed 0.06 sec
Start 11: kwin-testXcbSizeHints
11/23 Test #11: kwin-testXcbSizeHints ............ Passed 0.06 sec
Start 12: kwin-testXcbWindow
12/23 Test #12: kwin-testXcbWindow ............... Passed 0.06 sec
Start 13: kwin-testBuiltInEffectLoader
13/23 Test #13: kwin-testBuiltInEffectLoader ..... Passed 0.93 sec
Start 14: kwin-testScriptedEffectLoader
14/23 Test #14: kwin-testScriptedEffectLoader .... Passed 0.93 sec
Start 15: kwin-testPluginEffectLoader
15/23 Test #15: kwin-testPluginEffectLoader ...... Passed 1.26 sec
Start 16: kwin_testScreens
16/23 Test #16: kwin_testScreens ................. Passed 2.51 sec
Start 17: kwin-testXRandRScreens
17/23 Test #17: kwin-testXRandRScreens ...........</em></strong>Failed 0.01 sec
Start 18: kwin_testScreenEdges
18/23 Test #18: kwin_testScreenEdges .............<strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Failed 1.02 sec
Start 19: kwin-testStart
19/23 Test #19: kwin-testStart ...................</em></strong>Exception: SegFault 0.08 sec
Start 20: kwin-testTransientNoInput
20/23 Test #20: kwin-testTransientNoInput ........<strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Exception: SegFault 0.07 sec
Start 21: kwin-testQuickTiling
21/23 Test #21: kwin-testQuickTiling .............</em></strong>Exception: SegFault 0.07 sec
Start 22: kwin-testMoveResize
22/23 Test #22: kwin-testMoveResize ..............<strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Exception: SegFault 0.07 sec
Start 23: kwin-testDontCrashGlxgears
23/23 Test #23: kwin-testDontCrashGlxgears .......</em></strong>Exception: SegFault 0.07 sec</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">65% tests passed, 8 tests failed out of 23</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Total Test time (real) = 8.22 sec</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The following tests FAILED:
9 - kwin-testClientMachine (OTHER_FAULT)
17 - kwin-testXRandRScreens (Failed)
18 - kwin_testScreenEdges (Failed)
19 - kwin-testStart (SEGFAULT)
20 - kwin-testTransientNoInput (SEGFAULT)
21 - kwin-testQuickTiling (SEGFAULT)
22 - kwin-testMoveResize (SEGFAULT)
23 - kwin-testDontCrashGlxgears (SEGFAULT)
Errors while running CTest
FAILED: cd /home/kenya888/devel/kf5/build/kde/workspace/kwin && /usr/bin/ctest --force-new-ctest-process
ninja: build stopped: subcommand failed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>main_wayland.cpp <span style="color: grey">(48499cc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126008/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>