<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125973/">https://git.reviewboard.kde.org/r/125973/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">By the duplicated function you mean PlasmoidTask::showMenu(int x, int y)? That one has only two args and is missing the "run associated application" action, which I'm not entirely sure what's it used for. The rest indeed looks about the same (though the showMenu could really use some commentary)</p></pre>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On November 9th, 2015, 11:42 p.m. CET, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2015, 11:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Remove almost completely duplicated function.
One was used for right clicking on expanded items, the other for full compact items.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemtray/package/contents/ui/ExpandedRepresentation.qml <span style="color: grey">(a53be6cb0d9fae14e055a6d1381ad11fee0a236e)</span></li>
<li>applets/systemtray/plugin/host.h <span style="color: grey">(db6fc567666281c8b2fe81eab085ae4b950bf07d)</span></li>
<li>applets/systemtray/plugin/host.cpp <span style="color: grey">(61e87050826a28409e44c8dac5baebe12e59bf63)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125973/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>