<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125993/">https://git.reviewboard.kde.org/r/125993/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125993/diff/1/?file=415733#file415733line89" style="color: black; font-weight: bold; text-decoration: underline;">libs/mediacenter/pmcmetadatamodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">PmcMetadataModel::PmcMetadataModel(QObject* parent, MediaLibrary* mediaLibrary):</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">SingletonFactory</span><span class="o">::</span><span class="n">instanceFor</span><span class="o"><</span><span class="n">LastFmImageFetcher</span><span class="o">></span><span class="p">(),</span> <span class="o">&</span><span class="n">LastFmImageFetcher</span><span class="o">::</span><span class="n">imageFetched</span><span class="p">,</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since you removed this, I don't see any code that feeds this information into medialibrary, so if you clear the cache you won't get any fancy thumbnails for media files.</p></pre>
</div>
</div>
<br />
<p>- Bhushan Shah</p>
<br />
<p>On November 8th, 2015, 6:02 p.m. IST, Aditya Dev Sharma wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Ashish Bansal and Bhushan Shah.</div>
<div>By Aditya Dev Sharma.</div>
<p style="color: grey;"><i>Updated Nov. 8, 2015, 6:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Implemented it like the other datasources.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built and Tested.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(04ba1c3)</span></li>
<li>autotests/lastfmimagefetchertest.h <span style="color: grey">(eb7cb29)</span></li>
<li>autotests/lastfmimagefetchertest.cpp <span style="color: grey">(abb3fd6)</span></li>
<li>datasources/CMakeLists.txt <span style="color: grey">(a7171b7)</span></li>
<li>datasources/lastfm/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>datasources/lastfm/lastfmimagefetcher.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/mediacenter/CMakeLists.txt <span style="color: grey">(5a13449)</span></li>
<li>libs/mediacenter/lastfmimagefetcher.h <span style="color: grey">(ecff37e)</span></li>
<li>libs/mediacenter/lastfmimagefetcher.cpp <span style="color: grey">(e005077)</span></li>
<li>libs/mediacenter/pmcmetadatamodel.cpp <span style="color: grey">(2fe6efe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125993/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>