<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125942/">https://git.reviewboard.kde.org/r/125942/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 4th, 2015, 7:55 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125942/diff/1/?file=414799#file414799line143" style="color: black; font-weight: bold; text-decoration: underline;">src/server/display.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">143</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">removeOutputDevice</span><span class="p">(</span><span class="n">OutputDeviceInterface</span> <span class="o">*</span><span class="n">output</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why removeOutputDevice? We don't have that for any other Global.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We do, for Output. These should be as similar as possible, no? (Use case, a device gets unplugged at runtime.)</p></pre>
<br />
<p>- Sebastian</p>
<br />
<p>On November 4th, 2015, 2:49 a.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kwin, Plasma and Martin Gräßlin.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated Nov. 4, 2015, 2:49 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwayland
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This implements the client and server part of the screen management protocol. The protocol is implemented as a wayland protocol.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It provides the following mechanisms:
- a list of outputs, close to wl_output, with additional properties for enabled, uuid, edid, etc.. These OutputDevices correspond to a connected output that can be enabled by the compositor, but is not necessarily currently used for rendering.
- a global OutputManagement, which allows creating config objects, one per client. The client can make changes to the outputs through setScale(outputdevice*, scale) for example.
- an OutputConfiguration resource, that can be handed to a client and used for configuration. Changes are double buffered here. Only after OutputConfiguration.apply() has been called, the changes are relayed over the global OutputManagement.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The compositor is responsible to handle changes.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For a more detailed description, see the API docs in especially outputconfiguration.h.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The working branch for this is kwayland[sebas/kwin]. A backend for libkscreen is available in libkscreen[sebas/wayland].</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Unit tests pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/server/outputdevice_interface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/server/outputconfiguration_interface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/server/outputconfiguration_interface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/server/outputchangeset_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/server/outputchangeset.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/server/outputchangeset.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/server/display.cpp <span style="color: grey">(019991a)</span></li>
<li>src/server/display.h <span style="color: grey">(0fd1185)</span></li>
<li>src/server/CMakeLists.txt <span style="color: grey">(57eb763)</span></li>
<li>src/client/registry.cpp <span style="color: grey">(1a481c8)</span></li>
<li>src/client/registry.h <span style="color: grey">(034e38f)</span></li>
<li>src/client/protocols/outputdevice.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/protocols/output-management.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/outputmanagement.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/outputmanagement.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/outputdevice.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/outputdevice.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/outputconfiguration.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/outputconfiguration.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/CMakeLists.txt <span style="color: grey">(79092ef)</span></li>
<li>autotests/server/test_display.cpp <span style="color: grey">(b398812)</span></li>
<li>autotests/client/test_wayland_registry.cpp <span style="color: grey">(55f0f6c)</span></li>
<li>autotests/client/test_wayland_outputmanagement.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/client/test_wayland_outputdevice.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/client/CMakeLists.txt <span style="color: grey">(1556c47)</span></li>
<li>src/server/outputdevice_interface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/server/outputmanagement_interface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/server/outputmanagement_interface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tools/mapping.txt <span style="color: grey">(d6a4a44)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125942/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>