<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125871/">https://git.reviewboard.kde.org/r/125871/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 4th, 2015, 9:14 a.m. CET, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125871/diff/8/?file=414630#file414630line275" style="color: black; font-weight: bold; text-decoration: underline;">src/client/plasmawindowmodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 8)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">275</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">windows</span><span class="p">.</span><span class="n">at</span><span class="p">(</span><span class="n">row</span><span class="p">)</span><span class="o">-></span><span class="n">setMinimizedGeometry</span><span class="p">(</span><span class="n">panel</span><span class="p">,</span> <span class="n">geom</span><span class="p">.</span><span class="n">toRect</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why QRectF and then toRect()?</p></pre>
</blockquote>
<p>On November 4th, 2015, 10:32 a.m. CET, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">because qml iirc knows qrectf but not qrect</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ah right. Then my suggestion is to overload the method with a QRect and a QRectF variant.</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On November 4th, 2015, 10:49 a.m. CET, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Nov. 4, 2015, 10:49 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwayland
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this exposes the geometry of taskbar entries in plasma-windowmanagement, in order to make the minimize effects possible.
unlike on X11, it takes relative positions and it has one geometry per panel, making possible to have multiple taskbars working.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">however this is still not completely exposed, as internally kwin has still only one geometry, it will need a change in kwin itself (suggestions welcome) probably the rotocol will need also a minimizeTo function that takes the panel as argument.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">another thing completely missing is tests: unfortunately the whole plasma-windowmanagement doesn't have any autotest yet :/</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/server/plasmawindowmanagement_interface.cpp <span style="color: grey">(ad714a5)</span></li>
<li>src/server/plasmawindowmanagement_interface.h <span style="color: grey">(6ccc22e)</span></li>
<li>src/client/protocols/plasma-window-management.xml <span style="color: grey">(ca6a7cc)</span></li>
<li>src/client/plasmawindowmodel.cpp <span style="color: grey">(355ef53)</span></li>
<li>src/client/plasmawindowmodel.h <span style="color: grey">(5a6aac4)</span></li>
<li>src/client/plasmawindowmanagement.cpp <span style="color: grey">(1f9674c)</span></li>
<li>src/client/plasmawindowmanagement.h <span style="color: grey">(abd8fa6)</span></li>
<li>autotests/client/test_wayland_windowmanagement.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/client/CMakeLists.txt <span style="color: grey">(1556c47)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125871/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>