<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125618/">https://git.reviewboard.kde.org/r/125618/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">tested it and it works for me</p></pre>
<br />
<p>- Marcus Meissner</p>
<br />
<p>On October 27th, 2015, 8:45 a.m. UTC, Christian Butcher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Graphics, Plasma and Marcus Meissner.</div>
<div>By Christian Butcher.</div>
<p style="color: grey;"><i>Updated Oct. 27, 2015, 8:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kamera
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixes to the KameraConfigDialog dialogue problems, as seen in the screenshots attached to <a href="https://git.reviewboard.kde.org/r/125433/" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">this previous review</a>. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adds a QScrollArea (with no frame) to allow resizing more easily.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Labels are on the left side of the GridLayouts now, with their controls to the right (LineEdit, CheckBox, Slider).
The labels are almost the same in each of the three cases, but unsure that making just one Label, then changing based on an if() is an improvement.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested with Nikon 1 V2, which seems to have a significant number of available fields, and of varied types. Expect that not all <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">GP_WIDGET_{x,y,z}</code> are covered.
Tried to test with phone but uses MTP - Plasma and Dolphin allow me to open it nicely, and Kamera KCM shows the phone, but won't allow any actions on it.
Unsure if this means that the KCM should discard MTP phones with which it can't interface.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/kameraconfigdialog.cpp <span style="color: grey">(f8cdd43b9623ab26b868399ecf3e184c03b41d57)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125618/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>