<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125802/">https://git.reviewboard.kde.org/r/125802/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1, looks good to me. Let's give it some time for other devs to also have a look at it.</p></pre>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On October 26th, 2015, 9:11 a.m. CET, Bhushan Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Martin Gräßlin.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated Oct. 26, 2015, 9:11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Advantage of this split is some parts such as showLockWindow and hideLockWindow needs platform specific code. So instead of doing complex if/else branching we can have seperate X11Locker and WaylandLocker.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">builds, installs, autotests and kscreenlocker_test passes, normal lockscreen also works.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/CMakeLists.txt <span style="color: grey">(24a89f6)</span></li>
<li>ksmserver/screenlocker/abstractlocker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/abstractlocker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/autotests/CMakeLists.txt <span style="color: grey">(ab901ca)</span></li>
<li>ksmserver/screenlocker/autotests/lockwindowtest.cpp <span style="color: grey">(444c44f)</span></li>
<li>ksmserver/screenlocker/autotests/x11lockertest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/ksldapp.h <span style="color: grey">(b281ab6)</span></li>
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: grey">(68ebfc2)</span></li>
<li>ksmserver/screenlocker/lockwindow.h <span style="color: grey">(c4013be)</span></li>
<li>ksmserver/screenlocker/lockwindow.cpp <span style="color: grey">(e46733e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125802/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>