<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125810/">https://git.reviewboard.kde.org/r/125810/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some remarks, but otherwise, thanks for taking care of this.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125810/diff/1/?file=412832#file412832line172" style="color: black; font-weight: bold; text-decoration: underline;">applets/devicenotifier/package/metadata.desktop</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">172</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">X-KDE-FormFactors=tablet,mediacenter,desktop</pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Could you share the reasoning for this choice?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125810/diff/1/?file=412836#file412836line170" style="color: black; font-weight: bold; text-decoration: underline;">applets/notifications/package/metadata.desktop</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">170</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">X-KDE-FormFactors=handset,tablet,mediacenter,desktop</pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We have a special notifications applet for handsets in plasma-mobile, so this should probably be more limited (exactly the opposite keys of plasma-mobile's notifications applet).</p></pre>
</div>
</div>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On October 26th, 2015, 4:26 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Oct. 26, 2015, 4:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">added some formfactor keywords in the applets metadata. once the explorer model filters them accordingly, it should remove a bit of applets problematic on the phone for one reason or another</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/activitybar/metadata.desktop <span style="color: grey">(d6cf69c)</span></li>
<li>applets/analog-clock/metadata.desktop <span style="color: grey">(4246c6e)</span></li>
<li>applets/batterymonitor/package/metadata.desktop <span style="color: grey">(a4ee702)</span></li>
<li>applets/calendar/metadata.desktop <span style="color: grey">(5891264)</span></li>
<li>applets/clipboard/metadata.desktop <span style="color: grey">(1d699d2)</span></li>
<li>applets/devicenotifier/package/metadata.desktop <span style="color: grey">(d71ce72)</span></li>
<li>applets/digital-clock/package/metadata.desktop <span style="color: grey">(b881453)</span></li>
<li>applets/lock_logout/metadata.desktop <span style="color: grey">(f53f541)</span></li>
<li>applets/mediacontroller/metadata.desktop <span style="color: grey">(d4ea37a)</span></li>
<li>applets/notifications/package/metadata.desktop <span style="color: grey">(2beb20d)</span></li>
<li>applets/systemmonitor/cpu/metadata.desktop <span style="color: grey">(76cd74d)</span></li>
<li>applets/systemmonitor/diskactivity/metadata.desktop <span style="color: grey">(2a1ceaa)</span></li>
<li>applets/systemmonitor/diskusage/metadata.desktop <span style="color: grey">(08344a8)</span></li>
<li>applets/systemmonitor/net/metadata.desktop <span style="color: grey">(6671fba)</span></li>
<li>applets/systemtray/package/metadata.desktop <span style="color: grey">(0ce0512)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125810/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>