<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125770/">https://git.reviewboard.kde.org/r/125770/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks good, though do note that the spec you link to is a Gnome spec and Gnome doesn't really care that much. I've proposed sometime ago to update the Galago spec with it but "we host libnotify at Gnome servers and so we get to control the spec" was moreless the answer. So I don't care about that Gnome spec.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Nevertheless, the patch is still correct even wrt the Galago spec.</p></pre>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On October 24th, 2015, 2:40 p.m. CEST, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Oct. 24, 2015, 2:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Expired notifications should emit a different reason in
NotificationClosed than manually closed notifications</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See https://people.gnome.org/~mccann/docs/notification-spec/notification-spec-1.1.html#signal-notification-closed</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: 354293</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ran dbus-monitor & notify-send</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">let one notification expire
clicked close on another</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/notifications/package/contents/ui/NotificationPopup.qml <span style="color: grey">(5fd06bb4ee437e673ef9cc09907764b40cfa5a74)</span></li>
<li>applets/notifications/package/contents/ui/Notifications.qml <span style="color: grey">(13be7d49a14ebbe5399a7f0bf333862f545671a2)</span></li>
<li>dataengines/notifications/notificationaction.cpp <span style="color: grey">(5302f7808fd43c924a3f7b1fd7cfc0acba45c500)</span></li>
<li>dataengines/notifications/notifications.operations <span style="color: grey">(046776ec1af981d7fb23db9ddb9bd9d34ec55300)</span></li>
<li>dataengines/notifications/notificationsengine.h <span style="color: grey">(52590950ad1c85f427502b598e0b21d8a65e587e)</span></li>
<li>dataengines/notifications/notificationsengine.cpp <span style="color: grey">(42e56d8ab27b3a012381cbd0ce39c6322d09e152)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125770/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>