<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125678/">https://git.reviewboard.kde.org/r/125678/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 19th, 2015, 8:47 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Nice! But I wonder if wouldn't be better to have the whole plasmoid as a scrolling list instead of just the users scrolling and not the rest, it looks a bit werird. I know that technically the user list and the other functions are different things, but that shouldn't matter to the user (the other buttons could be in the footer of the listview)</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It might just look weird on this screenshot because the separator between the users and the leave options (which is important anyway) is covered mostly by the highlight here. This should be fixed, the separator has to be below the higlight.
It makes sense to me that the leave options are always directly visible and do not have to be scrolled to, because they are likely to be more important to a user than the 8th sessions in a list. Besides, in actual use, it's unlikely that so many sessions are running at the same time anyway (think of the memory!). Unless most of them are console sessions, and people who have lots of console sessions open at the sime time are likely to find Ctrl-Alt-FX to be more convenient for switching anyway.</p></pre>
<br />
<p>- Thomas</p>
<br />
<p>On October 17th, 2015, 6:11 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Oct. 17, 2015, 6:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is prety common in other desktop environments to have something that allows switching between users and logout/shutdown quickly. It is inspired by the Fast User Switch plasmoid from kde-apps.org [1]</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[1] http://kde-apps.org/content/show.php?content=127462</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When the applet opens, it updates. It grows a maximum of half the screen height, should there be more users currently logged in, the list can be scrolled. Switching users works, both with and without locking the screen, depending on user's settings. Opening new sessions, locking the screen and shutting down also work.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The applet doesn't have any settings, the label probably needs tweaking so its sizing policy is similar to the digital clock so the two look reasonable next to each other.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/userswitcher/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/userswitcher/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/userswitcher/package/contents/ui/ListDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/userswitcher/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/CMakeLists.txt <span style="color: grey">(4079726)</span></li>
<li>applets/userswitcher/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125678/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/17/05d93363-9b15-4c77-abe0-6f8ed9b3cab7__userswitcherplasmoid3.png">Plasmoid in action</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>