<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125686/">https://git.reviewboard.kde.org/r/125686/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">bye.</p></pre>
<br />
<p>- Thomas Lübking</p>
<br />
<p>On Oktober 18th, 2015, 11:23 vorm. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Okt. 18, 2015, 11:23 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Basically dead code given that Plasma doesn't have a dedicated dashboard
mode anymore and also doesn't set the required window role for it to
work.
By deleting we save one string comparison for each newly opened window.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles without the effect. Verified that "plasma-dashboard" is nowhere set in plasma-framework, plasma-workspace and plasma-desktop.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>effects/CMakeLists.txt <span style="color: grey">(3e88bfa754bf1581d5e951b602838746a3826acd)</span></li>
<li>effects/dashboard/CMakeLists.txt <span style="color: grey">(81c5ee1ff878904ab06153e2e316775218d799ae)</span></li>
<li>effects/dashboard/dashboard.h <span style="color: grey">(9c46f12ebf5c222ba91a9f153b1f84671c25de82)</span></li>
<li>effects/dashboard/dashboard.cpp <span style="color: grey">(42651ecce1b8a3189e5b47382b4915b76adb1aec)</span></li>
<li>effects/dashboard/dashboard.kcfg <span style="color: grey">(9fbdf09c5a45181f3099ef1e7a8777416f14d6b9)</span></li>
<li>effects/dashboard/dashboard_config.h <span style="color: grey">(aaa09d6fb9f3b82faa7a073826ca725e0739886e)</span></li>
<li>effects/dashboard/dashboard_config.cpp <span style="color: grey">(75696bd07b45ff0247fc39a8ca058bd392f2e681)</span></li>
<li>effects/dashboard/dashboard_config.desktop <span style="color: grey">(de25b623bcb79012f9bbb3222c1ac1916dbfdcea)</span></li>
<li>effects/dashboard/dashboard_config.ui <span style="color: grey">(fd9a19e0c5b979049fe7e3443974eef3286fb2f2)</span></li>
<li>effects/dashboard/dashboardconfig.kcfgc <span style="color: grey">(772ad03cbe6f5f213759d394a54eeede08411bf0)</span></li>
<li>effects/effect_builtins.h <span style="color: grey">(b471cf077a2bb284ac448229c9967b00023d8842)</span></li>
<li>effects/effect_builtins.cpp <span style="color: grey">(be508e6fea57be49a1bd320194f18aaeb1465f42)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125686/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>