<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125678/">https://git.reviewboard.kde.org/r/125678/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 18th, 2015, 9:26 a.m. UTC, <b>Heiko Tietze</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Nice user switcher. Question is whether or not the user icon is to show in the panel (clutters IMHO, so done right) and what happens when you click one of the global functions. The Lock/Logout plasmoid shows a confirmation bar with reboot, shut down, and log out (the latter enabled by default). Is this bar shown for leave? And actually I'd rather keep plasmoids simple and remove all features that are not directly related to user sessions. So it should be taken into consideration to remove Lock and Leave... (maybe add just logout).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And last but not least you could think about the sort order. If there are really more than one instance of the same user as in your screenshot, the current user may want to switch between own instances.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PS: New users may expect such a dialog for activities. Does mixing sessions and activities make sense?</p></pre>
</blockquote>
<p>On October 18th, 2015, 9:44 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Question is whether or not the user icon is to show in the panel</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I was thinking about it but decided against it because, yes, it clutters it.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is this bar shown for leave?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, pressing "Leave..." will open the Shutdown/Reboot/Logout dialog, that part is actually taken from the lock logout applet :)</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">not directly related to user sessions</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Locking the screen and logging off is related to the <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">current</em> session.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">remove Lock and Leave...</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't think telling someone "if you want to switch to the other user, click here, but if you want to just log out or lock the screen, click here, here, and here" (kickoff menu eg)</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If there are really more than one instance of the same user as in your screenshot, the current user may want to switch between own instances</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Makes sense, ie. sort the current user's sessions first, then the rest alphabetically? Or by VT (F1, F2, ..)? However, the sort order is not determined by the plasmoid but the separate model (Review 124980) and would (eventually) affect the regular user switcher and the one on the lock screen.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">| Yes, pressing "Leave..." will open the Shutdown/Reboot/Logout dialog, that part is actually taken from the lock logout applet :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OT: This confirmation bar shows "logout" (not "leave") by default, even when I clicked shutdown in the refering plasmoid.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Waiting for other replies...</p></pre>
<br />
<p>- Heiko</p>
<br />
<p>On October 17th, 2015, 6:11 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Oct. 17, 2015, 6:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is prety common in other desktop environments to have something that allows switching between users and logout/shutdown quickly. It is inspired by the Fast User Switch plasmoid from kde-apps.org [1]</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[1] http://kde-apps.org/content/show.php?content=127462</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When the applet opens, it updates. It grows a maximum of half the screen height, should there be more users currently logged in, the list can be scrolled. Switching users works, both with and without locking the screen, depending on user's settings. Opening new sessions, locking the screen and shutting down also work.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The applet doesn't have any settings, the label probably needs tweaking so its sizing policy is similar to the digital clock so the two look reasonable next to each other.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/userswitcher/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/userswitcher/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/userswitcher/package/contents/ui/ListDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/userswitcher/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/CMakeLists.txt <span style="color: grey">(4079726)</span></li>
<li>applets/userswitcher/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125678/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/17/05d93363-9b15-4c77-abe0-6f8ed9b3cab7__userswitcherplasmoid3.png">Plasmoid in action</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>