<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125655/">https://git.reviewboard.kde.org/r/125655/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">did you try whether the proxy works without compositing? I just hit the "suspend compositing" global shortcut to test something and it gave me bad rendering results in the davetray area.</p></pre>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On October 16th, 2015, 1:22 p.m. CEST, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Oct. 16, 2015, 1:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The goal of this project is to make xembed system trays available in Plasma.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] available in Plasma which only supports StatusNotifierItem [2].</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ideally we also want this to work in an xwayland session, making X system tray icons available even when plasmashell only has a wayland connection.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How it works (in theory)</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">We register a window as a system tray container</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">We render embeded windows composited offscreen</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">We render contents into an image and send this over DBus via the SNI protocol</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">XDamage events trigger a repaint</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Activate and context menu events are replyed via X send event into the embedded container as left and right clicks</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Code is a mix of hacks and bodges bashing client apps into place, and I happily acknowledge it looks pretty bad. Unfotunately most of it seems to be needed, but I'd love to be proved wrong on most of it.</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">CMakeLists changes are obviously currently wrong, I can strip half of find_packages and I need an add_subdirectory in the root file, but it's easier for me to sync with the separate repo mirror this way till we're close to merging. I expect this to take quite some revisions.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>xembedsniproxy/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/Readme.md <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/fdoselectionmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/fdoselectionmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/org.kde.StatusNotifierItem.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/org.kde.StatusNotifierWatcher.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/snidbus.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/snidbus.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/sniproxy.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/sniproxy.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/xcbutils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>xembedsniproxy/xembedsniproxy.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125655/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>