<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125657/">https://git.reviewboard.kde.org/r/125657/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 16th, 2015, 3:14 p.m. UTC, <b>Andrew Lake</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is it fair to interpret this as a possible path to reducing the duplication of icons between the main icon theme and the plasma theme?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yes, I want to keep some main ones in the plasma theme as some icons are actually composed from multiple elements in the same file and in general is slightly faster, but apart the main classical systray ones, some duplication could be removed</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On October 16th, 2015, 2:48 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Oct. 16, 2015, 2:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This makes IconItem try to load global icons from the theme with Plasma::Svg as well, making it assign the colors from the stylesheet if the breeze monochrome icons are treated, that should be scriptable, from some attempts i did the script seems to convert them correctly, without any change in rendering.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This will automatically color monochrome breeze icons only in plasmashell, and more specifically only those that use IconItem, not QIconItem (iconitem should probably have an animation-less mode to be able to be used in taskmanager and stuff)
perhaps in the future we'll be able somehow to hook all this stuff in QIconEngine to be able to use it in QWidget applications, but since QIcon does have any idea where it is, is not usable yet for things like the fullscreen fixed-dark gwenview view.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/iconitem.h <span style="color: grey">(3ef0306)</span></li>
<li>src/declarativeimports/core/iconitem.cpp <span style="color: grey">(692cd8d)</span></li>
<li>src/plasma/private/svg_p.h <span style="color: grey">(ab91c42)</span></li>
<li>src/plasma/svg.h <span style="color: grey">(3ad21ce)</span></li>
<li>src/plasma/svg.cpp <span style="color: grey">(37ced22)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125657/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>