<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125610/">https://git.reviewboard.kde.org/r/125610/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 12th, 2015, 4:58 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">won't this mean kdelibs4 progress notifications won't show up in plasma5?</p></pre>
</blockquote>
<p>On October 12th, 2015, 5:01 p.m. UTC, <b>Rex Dieter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Definite maybe, like I said, I'm not privy to exactly what this is used for. I mentioned on irc another approach, to simply drop/omit kuiserver bits from kde-runtime on distro's shipping with plasma5. Would that be better?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah, KUIserver is that notification when you're copying a big file in Dolphin and Plasma shows a progress bar.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think we could just not install that xml file from Plasma 5 (if that's easier than not installing it in kde-runtime)
KIO has it's own private copy which it uses which it uses to generate the sending code - and everything else will just use the library code in KIO.</p></pre>
<br />
<p>- David</p>
<br />
<p>On October 12th, 2015, 4:53 p.m. UTC, Rex Dieter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Rex Dieter.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2015, 4:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=351500">351500</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Exclusively use org.kde.kuiserver5 dbus service so it doesn't conflict with kde4's org.kde.kuiserver from kde-runtime</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Applied patch, confirmed kuiserver builds, and plasma still functions as expected (it runs on plasma session login). Admittedly, I'm not privy to kuiserver's detailed purpose, so wasn't sure how to test it specifically.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/applicationjobs/kuiserverengine.cpp <span style="color: grey">(93ef2d6)</span></li>
<li>kuiserver/CMakeLists.txt <span style="color: grey">(0f7c29e)</span></li>
<li>kuiserver/org.kde.kuiserver.service.in <span style="color: grey">(7a86d07)</span></li>
<li>kuiserver/org.kde.kuiserver.xml <span style="color: grey">(7d465bc)</span></li>
<li>kuiserver/org.kde.kuiserver5.service.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>kuiserver/org.kde.kuiserver5.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>kuiserver/progresslistmodel.h <span style="color: grey">(490a683)</span></li>
<li>kuiserver/progresslistmodel.cpp <span style="color: grey">(fe147f3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125610/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>