<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125562/">https://git.reviewboard.kde.org/r/125562/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 12th, 2015, 1:36 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">could we use if (id==0) rather than introducing new signals in p-f?</p></pre>
</blockquote>
<p>On October 12th, 2015, 3 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">looking at it, (and trying a patch that ended up very ugly and not really working) at the moment on plasma5 layout templates can only work for panels, as layout templates for desktops at the moment can only create new activities but there isn't any api in the desktop scripting to just create a Desktop containment.
and probably there shouldn't be, as creating a new Desktop containment via scripting would just create an "orphaned" containment that wouldn't really do anything and not be anywhere, except perhaps this kind of script, but just broken in setup scripts and in the interactive console.
So I think all considered, I prefer keeping layout templates just limited to their current use that is pre-populated panels that appear in the create panel context menu.
For desktop, layout templates would go back making sense if and only if the activity manager would again have a "create new activity of type..." option when creating activities as there was in KDE4, but not sure about it.
Otherwise just for default containments configs, I would just stick to the current patch form</p></pre>
</blockquote>
<p>On October 12th, 2015, 3:18 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">about id == 0 uhmm, at that point the containment is an existing one already so id would never be 0 in both cases..</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here is what I'd like to see:
- For every newly created user, the default Activity should be based on a layout template
- Being able to choose what type a newly created Activity should be and then setting it up accordingly still makes sense to me. If the feature from Plasma 4 wasn't used all that much, then that's probably because the Activity templates provided then were too radically different from typical desktop layouts. They were targeted to very specific usecases, probably too specific for people to create new Activities for them.
If we offer templates which cater more to different tastes than to to very specific tasks, they may well be more successful.</p></pre>
<br />
<p>- Thomas</p>
<br />
<p>On October 9th, 2015, 4:29 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Eike Hein.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Oct. 9, 2015, 4:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(draft) mutually exclusive with https://git.reviewboard.kde.org/r/125558/
a bit more flexible
different approach: execute a script from the look and feel package when an applet is added, adding to the script environment "applet" that wraps the currently added applet and "containment" that wraps its containment.
from there the javascript part can do anything it can do in the startup script as well.
Still missing, something similar will have to be executed when a new containment is added as well.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/packageplugins/lookandfeel/lookandfeel.cpp <span style="color: grey">(a6cef04)</span></li>
<li>shell/shellcorona.h <span style="color: grey">(0e6fe04)</span></li>
<li>shell/shellcorona.cpp <span style="color: grey">(37d0534)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125562/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>