<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125589/">https://git.reviewboard.kde.org/r/125589/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, KDE Usability and Eike Hein.</div>
<div>By Kai Uwe Broulik.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One thing that always bugged me with the Plasma 5 Task Manager was the context menu covering the task item (I have a top panel) when I, conforming to Fitt's Law, threw my mouse at the edge and right clicked.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This also restores Plasma 4 behavior where the context menus din't overlap the panels. I chose to align the context menu with the item itself rather than just the panel, which is what Plasma 4 did, to communicate some affinity to the task item, especially in multi-row task managers.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I changed the QMetaObject::invokeMethod to a QTimer::singleShot with lambda, don't know if that's the right approach. Also it's perhaps not optimal for me to copy the QPoint into the lambda.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested with single and multi row task manager in top/bottom/left/right panels. Works. Did not test with multiple monitors.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Perhaps some margins need to be taken into account additionally, note the small gap between the indicator line and the menu border</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/taskmanager/plugin/backend.h <span style="color: grey">(2b9d9e9)</span></li>
<li>applets/taskmanager/plugin/backend.cpp <span style="color: grey">(97ed755)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125589/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/10/f62b81df-4b0b-4b11-8c66-aa96dc56850a__taskmanageroverlap1.png">Outer left two columns</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/10/7b128305-04e8-4734-82d0-b1853bbc8471__taskmanageroverlap2.png">Inner left two columns</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>