<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125568/">https://git.reviewboard.kde.org/r/125568/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Octubre 9th, 2015, 10:40 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Finally new sticky notes \o/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm a bit sad about the loss of shadows around widgets. Also, I liked Plasma's configure icon much better and wish that one was put into the Breeze theme rather than vice-versa as it is now.</p></pre>
</blockquote>
<p>On Octubre 9th, 2015, 4:43 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I agree with the icon. I feel like it's changing every release or so.</p></pre>
</blockquote>
<p>On Octubre 9th, 2015, 7:45 p.m. UTC, <b>Uri Herrera</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yeah, the shadows.. I was intending on having the shadows the same way they're in the actual windows but I find it to be really hard to get it right. The super heavy shadow that was being used was a left-over from the Oxygen and Air themes. It is still using a shadow of course just not as heavy.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I added hamburger menu icon to the icon theme a while back.</p></pre>
</blockquote>
<p>On Octubre 9th, 2015, 10:28 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I added hamburger menu icon to the icon theme a while back.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The one on the notes applet. In the "before" screenshot, it's the two horizontal lines with circles, the "after" has a window of some sort. Before it was a wrench icon. I do agree with Kai that the horizontal-bars-with-circly-things looks better as a settings icon, the window of some sort is not that much telling.</p></pre>
</blockquote>
<p>On Octubre 9th, 2015, 10:32 p.m. UTC, <b>Uri Herrera</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That icon is the <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">literal</em> representation of the window that it opens.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><img alt="" src="http://i.imgur.com/axfxffD.png" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /></p></pre>
</blockquote>
<p>On Octubre 9th, 2015, 10:35 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yeah I get that. But I don't want to keep remembering the looks of windows to associate them with an icon/action (not mentioning the config window looks might change and that would change the icon (again) I presume). It's kind of like the "save" button all of a sudden getting a /literal/ looks of the save dialog instead of that floppy that everyone is so used to.</p></pre>
</blockquote>
<p>On Octubre 9th, 2015, 10:39 p.m. UTC, <b>Uri Herrera</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You did do that whenver you started using software that had the floppy as the save icon. You had to remember "this floppy icon means save" and now you're used to it. It's the same.</p></pre>
</blockquote>
<p>On Octubre 9th, 2015, 10:51 p.m. UTC, <b>Uri Herrera</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also the icon (the one with sliders) is for 1) Start menu categories 2) a somewhat small version of System Settings but not really and 3) a workaround for applications whose toolbar uses a category icon (the actual use) -</p></pre>
</blockquote>
<p>On Octubre 9th, 2015, 10:51 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But then again - this icon is being changed for the third time in 5 releases. By the time me and all our users got this association into mine/their minds, there comes the need to reassociate. This time with a window. Which I still think makes no sense. Especially since the config dialog is very likely /not/ going to look like this on Plasma Mobile. Hence the generic/symbolic representation of the action seems better fit rather than a /literal/ representation of the window.</p></pre>
</blockquote>
<p>On Octubre 9th, 2015, 10:58 p.m. UTC, <b>andreas kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But Uri use the config icon instead of the shortcut icon (old one) and about 3 changes in 5 releases. sorry we work heavy on the icons.</p></pre>
</blockquote>
<p>On Octubre 9th, 2015, 11:03 p.m. UTC, <b>Uri Herrera</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That's as simple to fix as Plasma mobile using a different icon and me making it. In fact it wasn't changed, it was missing. The one I made first was the one with the sliders (for the toolbars) and that was the one used when the current Breeze theme was made because it was the only icon for that action (configuration). The version before that was using assets from Oxygen and Air.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And I do understand what you mean, but, it's the same whenever we learn anything new. Always, we have to get used to it first. I (and Andreas of course) have changed other icons too over the course of the last year. Haven't seen that as a problem, setback, issue or cause of confusion for people using Breeze.</p></pre>
</blockquote>
<p>On Octubre 9th, 2015, 11:06 p.m. UTC, <b>andreas kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and of corse most icons were changed cause of a bug report</p></pre>
</blockquote>
<p>On Octubre 9th, 2015, 11:11 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">fix as Plasma mobile using a different icon and me making it</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Which is precisely what I would like to avoid in our software. There are just too many "configure" icons around. But oh well, why do I bother.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But that's exactly what you should be doing, use icons depending on the context, just because an icon "works" doesn't mean, like at all, that it should be used everywhere, regardless of whether is an action/status/category, that's exactly why I had (and still have) workaround icons in the theme. Because icons were not used properly and were used just becasue "they worked". And come on now there's only 2 configure icons... that's not too many.</p></pre>
<br />
<p>- Uri</p>
<br />
<p>On Octubre 9th, 2015, 8:18 p.m. UTC, Uri Herrera wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Uri Herrera.</div>
<p style="color: grey;"><i>Updated Oct. 9, 2015, 8:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">SVG elements done from scratch, reused only a small portion of the existing files. Colors now match Breeze colorscheme. Buttons now match widget style. Icons in the system tray are taken from the icon theme. Icons in Kickoff are not monochromatic as only 16px and 22px icons are monochrome in Breeze. Better padding overall for elements. New visual for both task manager widgets that matches the states of the buttons. Checkboxes, radio buttons, sliders and scrollbars now have the colors used in the Breeze colorscheme.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><img alt="Before" src="http://i.imgur.com/Cz2JNee.png" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<img alt="After" src="http://i.imgur.com/hiZlyrb.png" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><img alt="Elements after" src="http://i.imgur.com/uMFsMzp.png" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<img alt="Elements before" src="http://i.imgur.com/pIs1CZ2.png" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /></p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125568/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>