<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125558/">https://git.reviewboard.kde.org/r/125558/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 8th, 2015, 4:07 p.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe we should do <packagename>/defaultrc?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should we use scripting instead to allow computed defaults?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do we somehow need to allow different defaults depending on containment or does that make no sense?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">a defaults config file already exist, i could merge it with this one, but i tought it's easier to have them separed if distributions want to customize only plasmoids and not the rest (like ksplash theme) that they would have to copy over the default file.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">about using scripting, it could be useful to manage more complicated scenarios, but I wouldn't know how to do it, as that place in containmentprivate is the only safe place to poke with the configuration, since is te exact spot in which the applet has been created, it already has an id, but the configuration hasn't been read yet and the kconfigskeleton hasn't been created yet, and being in plasma-framework I can't use scripting there, as is all in plasmashell.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">to use scripting i would have to execute it way after from plasmashell, so the applet would be created with the default configuration that would then be overwritten with the applet then reacting at the change (perhaps in some cases could even be visible in the ui the applet adapting itself)
it would be a bit messier, even tough possible.. so that largely depends how much is needed scripting.
like, how much conditional config values that can be reliably computed only there are needed</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On October 8th, 2015, 3:54 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2015, 3:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">with this patch (and a small adaption in plasma-workspace) if the look and feel package contains a file called "defaultappletconfig" with a form like</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[Applets][org.kde.plasma.analogclock]
showSecondHand=true</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">all newly created applets, from either the widget explorer or the scripting shell will have such configuration, in the example all analog clocks would have the seconds hand shown by default.
present applets configured differently are not affected</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/corona.h <span style="color: grey">(36ae60b)</span></li>
<li>src/plasma/corona.cpp <span style="color: grey">(f8d5c7d)</span></li>
<li>src/plasma/private/containment_p.cpp <span style="color: grey">(3836772)</span></li>
<li>src/plasma/private/corona_p.h <span style="color: grey">(2ee13a5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125558/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>