<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125522/">https://git.reviewboard.kde.org/r/125522/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 7th, 2015, 2:14 p.m. UTC, <b>Hugo Pereira Da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should also be checked when compiling against kde4 (cmake -DUSE_KDE4=1)
As far as I can tell, right now it does not compile there.
Also, concerning the added release, and other hacks, this was needed because in the past at least, when dragging the window, you would immediatly after miss one click as well as hover highlight.
I'll double check if this is still the case (against kf5).</p></pre>
</blockquote>
<p>On October 7th, 2015, 2:18 p.m. UTC, <b>Hugo Pereira Da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ok. So against kf5 it seems to be working just fine indeed.
So just need fixing the compilation against kde4, as well as compilation warnings
(namely:
/home/hpereira/kf5/src/kde/workspace/breeze/kstyle/breezewindowmanager.cpp: In member function ‘bool Breeze::AppEventFilter::appMouseEvent(QObject<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, QEvent</em>)’:
/home/hpereira/kf5/src/kde/workspace/breeze/kstyle/breezewindowmanager.cpp:148:22: warning: unused variable ‘window’ [-Wunused-variable]
QWidget<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> window( _parent->_target.data()->window() );
^
/home/hpereira/kf5/src/kde/workspace/breeze/kstyle/breezewindowmanager.cpp: At global scope:
/home/hpereira/kf5/src/kde/workspace/breeze/kstyle/breezewindowmanager.cpp:144:14: warning: unused parameter ‘event’ [-Wunused-parameter]
bool appMouseEvent( QObject</em>, QEvent* event )
)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks !</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So maybe only remove the hack for KF5?</p></pre>
<br />
<p>- David</p>
<br />
<p>On October 7th, 2015, 2:40 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Hugo Pereira Da Costa.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated Oct. 7, 2015, 2:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also remove hack that messes with cursor position, which results in window sometimes rendered in wrong position for a moment after starting window move.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure why there was added a button release before ungrabbing pointer in startDrag(), but it works fine without it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Moving windows still works.
I cannot reproduce the issue described in comment of the mentioned hack.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstyle/breezewindowmanager.h <span style="color: grey">(7989052)</span></li>
<li>kstyle/breezewindowmanager.cpp <span style="color: grey">(a9ad7ee)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125522/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>