<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125453/">https://git.reviewboard.kde.org/r/125453/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The versioning of the interface is not yet correctly represented: in registry.cpp the supported version needs to be changed to match the version and on server side it also needs to be incremented. New requests need to get an additional attribute since="2". The wayland-scanner will generate defines for them for easy comparing the versions.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In general the idea is that client and server negotiate the protocol version and thus we need to introduce version checks. On client side it's unfortunately not fully supported by us not having a min version check yet. But for this protocol it shouldn't matter as we can assume that KWin supports the latest.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also please add some documentation (yes I know it's lacking) with at least an @since 5.5</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125453/diff/1/?file=408693#file408693line20" style="color: black; font-weight: bold; text-decoration: underline;">src/client/protocols/plasma-shell.xml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nt"><interface</span> <span class="na">name=</span><span class="s">"org_kde_plasma_shell"</span> <span class="na">version=</span><span class="s">"1"</span><span class="nt">></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nt"><interface</span> <span class="na">name=</span><span class="s">"org_kde_plasma_shell"</span> <span class="na">version=</span><span class="s">"1<span class="hl">.1</span>"</span><span class="nt">></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">version increase by integer numbers, so it's 2</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125453/diff/1/?file=408694#file408694line20" style="color: black; font-weight: bold; text-decoration: underline;">src/client/protocols/plasma-window-management.xml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nt"><interface</span> <span class="na">name=</span><span class="s">"org_kde_plasma_window_management"</span> <span class="na">version=</span><span class="s">"1"</span><span class="nt">></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nt"><interface</span> <span class="na">name=</span><span class="s">"org_kde_plasma_window_management"</span> <span class="na">version=</span><span class="s">"1<span class="hl">.1</span>"</span><span class="nt">></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">same here</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125453/diff/1/?file=408698#file408698line530" style="color: black; font-weight: bold; text-decoration: underline;">src/server/plasmawindowmanagement_interface.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PlasmaWindowInterface::setMaximizeable(bool set)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">530</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">PlasmaWindowInterface</span><span class="o">::</span><span class="n">setSkipsTaskbar</span><span class="p">(</span><span class="kt">bool</span> <span class="n">set</span><span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">531</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">{</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">532</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">setState</span><span class="p">(</span><span class="n">ORG_KDE_PLASMA_WINDOW_MANAGEMENT_STATE_SKIPSTASKBAR</span><span class="p">,</span> <span class="n">set</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">533</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">}</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this needs a version check in some way: only if the bound resource supports version 2, we should set the state.</p></pre>
</div>
</div>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On September 29th, 2015, 8:26 p.m. CEST, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2015, 8:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwayland
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">support the skiptTaskbar property in the window model
that property is set client side by
PlasmaShell::setSkipsTaskbar</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/client/plasmashell.h <span style="color: grey">(6692300f820daa44c9363143463dfb8433bcdddc)</span></li>
<li>src/client/plasmashell.cpp <span style="color: grey">(4daaecffee9d45ebf4a783bfff9b33e9572fca22)</span></li>
<li>src/client/plasmawindowmanagement.h <span style="color: grey">(6e36def79719a7115ea41189746f871f5ffc6e70)</span></li>
<li>src/client/plasmawindowmanagement.cpp <span style="color: grey">(f6279d9c470cd153b65bc13f0ee12d631a370b16)</span></li>
<li>src/client/plasmawindowmodel.h <span style="color: grey">(49a211569cc5a8fe9ce237230a3acea0f8e5f384)</span></li>
<li>src/client/plasmawindowmodel.cpp <span style="color: grey">(ceba6ce8fa75d565e4ace435d08446b604b58bc4)</span></li>
<li>src/client/protocols/plasma-shell.xml <span style="color: grey">(7d33236dae6cf9571e98b8ccef6b377f76a7d99f)</span></li>
<li>src/client/protocols/plasma-window-management.xml <span style="color: grey">(a5bd639299a1e1af587f46369e4388eae02382c4)</span></li>
<li>src/server/plasmashell_interface.h <span style="color: grey">(228cbb1965da72d3dd73a1e73d97c04a80bc0b78)</span></li>
<li>src/server/plasmashell_interface.cpp <span style="color: grey">(32fd38906c3c55c678af40786ae6061465732046)</span></li>
<li>src/server/plasmawindowmanagement_interface.h <span style="color: grey">(c348d653882d3bc66d81679d05b1886d388aa32a)</span></li>
<li>src/server/plasmawindowmanagement_interface.cpp <span style="color: grey">(d6c71ae0584cf12b1ae89cae0948d66b7b349e4c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125453/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>