<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125135/">https://git.reviewboard.kde.org/r/125135/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 16th, 2015, 4:22 nachm. UTC, <b>andreas kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi I add some applet icons in 256x256px in kde:breeeze (https://quickgit.kde.org/?p=breeze.git&a=commit&h=f75b729531a75df1536b7340fcb016a5752ebf69)
I need feedback how it looks and if it would work for you</p></pre>
</blockquote>
<p>On September 16th, 2015, 6:01 nachm. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">snapshot8 that's how the calendar svg looks on the current code
(had to copy it by hand as they are not installed atm, also i'm not sure applets/ subfolder in the icon theme would work)</p></pre>
</blockquote>
<p>On September 21st, 2015, 3:42 nachm. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">for how iconloader works i think they should be in the apps folder, even tough technically thye are anot apps...</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would wrote an mail to plasma now. so you are to fast for me.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi,</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">only to your information as we sugested in the past. we will add for the plasma-xxx applets, application icons.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you can find them in kde:breeze in the folder /icons/applets/256/xxx</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the application icons are no screenshots and will be available for breeze and breeze-dark (so breeze dark will have the plasma dark border)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">icon name is something like org.kde.plasma.xxx</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">as Marco wrote they are still applications.</p></pre>
<br />
<p>- andreas</p>
<br />
<p>On September 21st, 2015, 1:20 nachm. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and andreas kainz.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Sept. 21, 2015, 1:20 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As requested by the VDG, show screenshots in the widget explorer when available, to have a look similar to the activity manager (they'll do screenshots for all our plasmoids).
when a screenshot is not available, it falls back to the old design.
this is an in-between design, the latest design would be with two columns instead of one, but that would need to be tested as well beforehand, both in the widget explorer and the activity switcher</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktoppackage/contents/explorer/AppletDelegate.qml <span style="color: grey">(7ded06e)</span></li>
<li>desktoppackage/contents/explorer/WidgetExplorer.qml <span style="color: grey">(f164c18)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125135/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png">snapshot6.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/955b1dbc-2347-4e17-beb1-c5153b3d0087__snapshot7.png">more near to the intended design</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/16/23447d32-815e-48c0-9a00-3234ee28249e__snapshot8.png">snapshot8.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>