<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125307/">https://git.reviewboard.kde.org/r/125307/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Rosca.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is now possible to set preferred icon theme in desktoptheme metadata.desktop.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As discussed on ML, this fixes using light breeze icon theme with breeze dark desktoptheme.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Icon theme is picked correctly with PlasmaCore.IconItem. Changing the desktoptheme updates the icons.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/theme.cpp <span style="color: grey">(c49ad4c)</span></li>
<li>src/plasma/private/theme_p.cpp <span style="color: grey">(31a6512)</span></li>
<li>src/plasma/theme.h <span style="color: grey">(3f49719)</span></li>
<li>src/desktoptheme/breeze/metadata.desktop <span style="color: grey">(07bbfc3)</span></li>
<li>src/plasma/private/theme_p.h <span style="color: grey">(5b8f71c)</span></li>
<li>src/declarativeimports/core/iconitem.h <span style="color: grey">(3ef0306)</span></li>
<li>src/declarativeimports/core/iconitem.cpp <span style="color: grey">(692cd8d)</span></li>
<li>src/desktoptheme/breeze-dark/metadata.desktop <span style="color: grey">(77647a4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125307/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>