<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125134/">https://git.reviewboard.kde.org/r/125134/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 17th, 2015, 1:07 nachm. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">updates?
regardless if screenshots end up being used in the widget explorer applets or not, I would add the possibility in order to ghns plasmoids to provide one</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes please.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As I wrote in another reviewrequest I added yesterday 3 applet "icons" ordinary icons are located in kde:breeze /icons/... but I can move them also to the plasma applet folder. please let me know where you want to have the screenshots and the icons. now the icons are included into the index.theme file so when you use the "right" icon name applets-analog-clock (applets-widget folder name).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As Icons are in kde:breeze I would prefere to have them there. Than I can also provide different 256px icons for breeze, breeze-dark and oxygen (when I would like) but I don't know how it would work with different form factors (do the different form fators have really the same app-name). and for GHNS the screenshots should be shipped with the package.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please let me know what you want Marko and I will prepare it. I'm open for everything. Also for making the icons if needed.</p></pre>
<br />
<p>- andreas</p>
<br />
<p>On September 10th, 2015, 11:36 vorm. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and andreas kainz.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Sept. 10, 2015, 11:36 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As suggested by the VDG, add the possibility to have screenshots for plasmoids.
the widget explorer will be modified as well to show the screenshots in the applet list when available</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp <span style="color: grey">(99e9add)</span></li>
<li>components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h <span style="color: grey">(f9cc89f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125134/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>