<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125295/">https://git.reviewboard.kde.org/r/125295/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[00:35] <fredrikh> d_ed: "valgrind warning about something about a thing" = "invalid read of size 4 [...] inside a block of size 1 alloc'd"?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[00:36] <fredrikh> d_ed: it's an 8 bit property as indicated by format_return, and your patch fixes it by not casting the unsigned char pointer to a Bool (aka int) before dereferencing it
[00:40] <fredrikh> because the latter tells the compiler to do a 32 bit read, while the former tells it to do an 8 bit read and cast the resulting value to 32 bit</p></pre>
<br />
<p>- David Edmundson</p>
<br />
<p>On September 17th, 2015, 9:26 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2015, 9:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We fetch 32 bits of data in XIGetProperty
This should be casted into a Bool, which comes from Xlib which is set to
an int (also always 32 bits).
The current code casts it to Bool* which is arch dependent, meaning on
64 bit systems we just read random data.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/input/mouse.cpp <span style="color: grey">(c2bd0d0131339d835bf26f5e09768b96875c3142)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125295/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>