<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125198/">https://git.reviewboard.kde.org/r/125198/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 14th, 2015, 6:05 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 - as a note: in openSUSE users were quite angry that we had broken session management, they won't be glad about the choice. My personal opinion is (as many probably known) that I would drop all session management support as I consider it as a relict from pre-suspend times.</p></pre>
</blockquote>
<p>On September 14th, 2015, 8:54 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I still tend to prefer it to suspend, starts things kindof where i was but slightly more clean slate than suspend (maybe is also due that i still do find suspend unreliable and horribly slow with 8 or more GB of ram).
It's fine to disable it by default, but the thing I'm afraid is that it may break again without being noticed, and i definitely want to keep it and keep it working for the time being.</p></pre>
</blockquote>
<p>On September 15th, 2015, 8:43 a.m. UTC, <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Suspend to harddisk is sometimes weirdly broken. Suspend in general has some hardware detection problems (see steamos suspend disabled because usb devices do not get detected when coming out of suspend). At the same time as I mentioned yesterday on IRC session restore often requires explicit support to be implemented on an application level which also renders it part-defunct depending on the applications one uses as the application will often just come up with the default UI state which conceptually is not "restoring" but "reopening". All in all both options are meh at times.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, I'd argue that suspend should be the go-to choice for the "restore" feature and we should demote session management as a "reopening"-only feature. Specifically that means changing the name and advertising it in that fashion which is line with what Kai suggested above as reopening is a much more immediate choice you want to make on logout actions. This also means that we'd consider it correct behavior if an application comes up in its default UI state. If an application chooses to implement restore that is cool as well but not required from a UX POV.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">may make sense, i don't like much the layout, would be probably be better on the same line of the button at the right of the screen (but then i fear seeing that line of text in german :/)</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On September 12th, 2015, 3:37 p.m. UTC, Harald Sitter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated Sept. 12, 2015, 3:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As requested by the VDG.
Rationale being that starting with an empty session all the time is
substantially less aggressive than potentially starting a gazillion
applications slowing down startup and greeting the user with a
cluttered desktop.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">installed. wiped ksmserverrc. multiple logins always result in an empty session.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/main.cpp <span style="color: grey">(4808a80081c3f4322c0d1b3223fc65bcbfeb26c1)</span></li>
<li>ksmserver/shutdown.cpp <span style="color: grey">(636ae66fcce1d5c39fd697925b9094abc44e4808)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125198/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>