<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125222/">https://git.reviewboard.kde.org/r/125222/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 14th, 2015, 4:09 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125222/diff/2/?file=403286#file403286line39" style="color: black; font-weight: bold; text-decoration: underline;">applets/quicklaunch/package/contents/code/layout.js</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="nb">Math</span><span class="p">.</span><span class="nx">ceil</span><span class="p">(</span><span class="nx">grid</span><span class="p">.</span><span class="nx">count</span> <span class="o">/</span> <span class="nx">maxSectionCount</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">can you verify that if grid.count changes dinamically, this cols() gets re-evaluated immediately?</p></pre>
</blockquote>
<p>On September 14th, 2015, 5:26 p.m. UTC, <b>David Rosca</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not really sure how to test it, but I added debug output and got this right after adding item to model:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">(qml) appendUrl: adding item to model
(qml) appendUrl: added item to model
(qml) onCountChanged: grid count changed
(qml) cols: cols called
(qml) cols: cols called
(qml) cols: cols called
(qml) cols: cols called
</pre></div>
</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yep, it works :)</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On September 14th, 2015, 3:54 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2015, 3:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a reimplementation of Quicklaunch applet in QML.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have tried to make it as similar to the original applet as possible.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Missing features:
- popup drawer for launchers
- option for automatically determining number of rows/cols (must be set manually)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/CMakeLists.txt <span style="color: grey">(2e29bbe)</span></li>
<li>applets/quicklaunch/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch/package/contents/code/layout.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch/package/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch/package/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch/package/contents/ui/ConfigGeneral.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch/package/contents/ui/IconItem.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch/package/contents/ui/UrlModel.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch/plugin/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch/plugin/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch/plugin/quicklaunch_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch/plugin/quicklaunch_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch/plugin/quicklaunchplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch/plugin/quicklaunchplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125222/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png">Empty applet</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png">On desktop (2 rows)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png">On desktop with names + dragging</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png">In vertical panel</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png">Context menu</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>