<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125174/">https://git.reviewboard.kde.org/r/125174/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2015, 11:11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a reimplementation of Quicklaunch applet in QML.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have tried to make it as similar to the original applet as possible.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Missing features:
- popup drawer for launchers
- option for automatically determining number of rows/cols (must be set manually)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For the review purposes, I have generated diff with code in "quicklaunch-qml" directory, but it should go to the original "quicklaunch" dir.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/CMakeLists.txt <span style="color: grey">(40c2e05)</span></li>
<li>applets/quicklaunch-qml/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch-qml/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch-qml/package/contents/code/layout.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch-qml/package/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch-qml/package/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch-qml/package/contents/ui/IconItem.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch-qml/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch-qml/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch-qml/plugin/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch-qml/plugin/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch-qml/plugin/quicklaunch_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch-qml/plugin/quicklaunch_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch-qml/plugin/quicklaunchplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125174/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png">Empty applet</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png">On desktop (2 rows)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png">On desktop with names + dragging</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png">In vertical panel</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png">Context menu</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>