<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125019/">https://git.reviewboard.kde.org/r/125019/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I currently don't want to make this configurable because I want to retain control over how Dashboard is presented to users and not allow it to be configured to a state that looks bad (this is a corner we've painted ourselves into too many times). The Dashboard layout will also be tweaked further, and until it settles down it's not clear what can be safely made configurable. Beyond that this patch would have some implementation issues, e.g. we don't want to expose icon sizes in numeric form to the user. I appreciate the idea and the attempt, but I'm going to reject this patch for now.</p></pre>
<br />
<p>- Eike Hein</p>
<br />
<p>On September 12th, 2015, 12:41 a.m. UTC, Takahiro Hashimoto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Takahiro Hashimoto.</div>
<p style="color: grey;"><i>Updated Sept. 12, 2015, 12:41 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The kicker dashboard icons are auto-adjusted by screen size (small or not) now. In certain environment (especially high-DPI screen like 4k) it would be nice to change icon size manually, I think.
This patch makes icon size of dashboard changeable from dashboard settings. The default behavior is auto setting by screen size. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's request for comment. I also think the simple implementation is better to avoid complex settings.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Screenshot attached.</p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">current icon size (determined by screen size, units.iconSizes.huge (equals 64)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">scale to 128 by this change (=units.iconSizeds.Enormous (equals 128)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">dashboard settings to change icon size (slidebar)</li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Could we discuss about this?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested on the two environment:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">high-dpi 3200x1800 DPI 150
normal-dpi 1024x768 DPI 96</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Both are tested with my Dell XPS 13 (2015) QHD+ machine.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kicker/package/contents/config/main.xml <span style="color: grey">(17cd29a)</span></li>
<li>applets/kicker/package/contents/ui/ConfigGeneral.qml <span style="color: grey">(ebb1342)</span></li>
<li>applets/kicker/package/contents/ui/DashboardRepresentation.qml <span style="color: grey">(eeb4837)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125019/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/ba2fedc2-b1cf-490f-9912-16fe41d02191__dash_icon_auto_QHD.png">1. current icon size (auto) QHD+</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/7a1e4257-6214-4597-b1ff-db0e6dbdf78d__dash_icon_scaleto128_QHD2.png">2. scale icon size to 128 with this change</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/d302f514-e9bb-4e42-a600-4f636f646990__dash_icon_gui_settings_menu.png">3. dashboard settings gui for changef icon size</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>