<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125135/">https://git.reviewboard.kde.org/r/125135/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 10th, 2015, 11:43 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">First of all, I like the idea.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">However, I think we should go with PNG with alpha channel rather than having the Breeze default wallpaper there which changes every release. Showing a fully working Plasmoid is probably too much in this list in terms of performance but might be worth thinking allowing a plasmoid to provide a demo.qml (eg. analog clock's face is pretty isolated) which is then shown there and in sync with the actual Plasmoid by using parts of it.
On the other hand, Android also just shows screenshots :)</p></pre>
</blockquote>
<p>On September 10th, 2015, 11:51 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i think as well having an alpha channel would be much prettier, however would require a specialized tool and would be slightly harder to do, needs to be as easy and fast for the VDG people to do them quickly. (also applets that make sense only as an expanded popup like kickoff would work better with the wallpaper i think?)</p></pre>
</blockquote>
<p>On September 10th, 2015, 12:06 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">maybe we could get an easy "screenshot mode" into plasmoidviewer? So that it
- hides the background
- uses correct size
- saves it with a standardized name</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Kickoff exposes another problem: some applets will need KWin help. Taking the screenshot without a background won't work for them, though the background hardly matters if we get the area around as translucent.</p></pre>
</blockquote>
<p>On September 10th, 2015, 1:36 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I too am worried about the screenshots getting out of date. Just for this release the digital-clock got some serious overhaul in its looks. Now I'm not opposed to the idea itself, but I don't think this scales too well. This would need a dedicated person to review _all_ applets before release and compare the screenshots...and from experience I don't believe we can keep this up.</pre>
</blockquote>
<p>On September 11th, 2015, 2:10 p.m. UTC, <b>andreas kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ok the proposal from the VDG (Uri and me)</p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">we will push 128x128px Previews in our kde:breeze icon set in breeze/icons/apps/128 in an first step we ONLY have screenshots</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">we will make 128x128px colorefull Icons and remove the screenshots with svg breeze and breeze dark icons where the user can recognize the difference behavior for the different widgets instead of something like this (https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/screenshot1.png)</li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So in the first step you have to live with screenshots BUT in the end you get large widget icons where the user can recognize the widget.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also for GHNS most widgets will only have at lease screenshots so it will be always a mix between icons and screenshots, but as you know me will focus on feature complete.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">would this way work for you? For now the screenshots would work and before the screenshots are not up to date the screenshots will be removed with icons AND the widget icons are useing in the same behavior than all other icons so the screenshots are in our structure and we will care about it.</p></pre>
</blockquote>
<p>On September 11th, 2015, 2:33 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">that's ok for me, so it will have screenshots in the short term and ad hoc icons in the long term.
the icon names will be the same as the plugin name, so all desktop files will need to have an updated Icon=org.kde.plasma.analogclock entry.
screenshots inside the plasmoid package still supported, intended for kdelook plasmoids that won't have an icon in the breeze theme.
how does it sound?</p></pre>
</blockquote>
<p>On September 11th, 2015, 3:08 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't want to discourage you from your effort, not at all, but isn't it kind of a wasted work? I mean, you spend all that time on making all those screenshots and then just remove then again anyway...? Wouldn't it be better to spend the time on the icons directly?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No it would be much more usefull to use the screenshots instead of some app icons cause you add widgets cause you want to have the screenshot on your desktop. The Icons are the wast of time cause they doesn't make sense but make widget icons is better for the user than it is now.</p></pre>
<br />
<p>- andreas</p>
<br />
<p>On September 10th, 2015, 10:53 a.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and andreas kainz.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Sept. 10, 2015, 10:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As requested by the VDG, show screenshots in the widget explorer when available, to have a look similar to the activity manager (they'll do screenshots for all our plasmoids).
when a screenshot is not available, it falls back to the old design.
this is an in-between design, the latest design would be with two columns instead of one, but that would need to be tested as well beforehand, both in the widget explorer and the activity switcher</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktoppackage/contents/explorer/AppletDelegate.qml <span style="color: grey">(7ded06e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125135/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png">snapshot6.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>