<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125135/">https://git.reviewboard.kde.org/r/125135/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 10th, 2015, 1:43 p.m. CEST, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">First of all, I like the idea.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">However, I think we should go with PNG with alpha channel rather than having the Breeze default wallpaper there which changes every release. Showing a fully working Plasmoid is probably too much in this list in terms of performance but might be worth thinking allowing a plasmoid to provide a demo.qml (eg. analog clock's face is pretty isolated) which is then shown there and in sync with the actual Plasmoid by using parts of it.
On the other hand, Android also just shows screenshots :)</p></pre>
</blockquote>
<p>On September 10th, 2015, 1:51 p.m. CEST, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i think as well having an alpha channel would be much prettier, however would require a specialized tool and would be slightly harder to do, needs to be as easy and fast for the VDG people to do them quickly. (also applets that make sense only as an expanded popup like kickoff would work better with the wallpaper i think?)</p></pre>
</blockquote>
<p>On September 10th, 2015, 2:06 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">maybe we could get an easy "screenshot mode" into plasmoidviewer? So that it
- hides the background
- uses correct size
- saves it with a standardized name</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Kickoff exposes another problem: some applets will need KWin help. Taking the screenshot without a background won't work for them, though the background hardly matters if we get the area around as translucent.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I too am worried about the screenshots getting out of date. Just for this release the digital-clock got some serious overhaul in its looks. Now I'm not opposed to the idea itself, but I don't think this scales too well. This would need a dedicated person to review _all_ applets before release and compare the screenshots...and from experience I don't believe we can keep this up.</pre>
<br />
<p>- Martin</p>
<br />
<p>On September 10th, 2015, 12:53 p.m. CEST, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and andreas kainz.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Sept. 10, 2015, 12:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As requested by the VDG, show screenshots in the widget explorer when available, to have a look similar to the activity manager (they'll do screenshots for all our plasmoids).
when a screenshot is not available, it falls back to the old design.
this is an in-between design, the latest design would be with two columns instead of one, but that would need to be tested as well beforehand, both in the widget explorer and the activity switcher</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktoppackage/contents/explorer/AppletDelegate.qml <span style="color: grey">(7ded06e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125135/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png">snapshot6.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>