<div dir="ltr"><div><div><div><div><div><div>Generate the preview would be nice BUT really difficult cause you should look that the plasmoid fits into an square.<br><br></div>about kwin screenshots I will have a look at if, if you like because also the KCM HIG is defined like that:<br><br></div>Preview where you can add or select and an panel on buttom of the preview with an advanced button. so yes the previews should be maintained as the icons too. It cost a lot of time to make the app icons for each plasmoid.<br><br></div>we are going in the direction of using more previews according to the HIGs. Also how the text above the preview is looking is according to our HIGs. So ....<br><br></div>I understand that the previews of an plasmoid could be outdated but than the plasma theme was changed or the plasmoid get rewritten. We will add in the HIG that each plasmoid have to have an 256x256px preview in there package (GHNS) and that's it.<br><br></div>thanks<br></div>Andreas<br></div><div class="gmail_extra"><br><div class="gmail_quote">2015-09-10 13:02 GMT+02:00 Martin Gräßlin <span dir="ltr"><<a href="mailto:mgraesslin@kde.org" target="_blank">mgraesslin@kde.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><span class="">
<table style="border:1px #c9c399 solid;border-radius:6px" bgcolor="#f9f3c9" width="100%" cellpadding="12">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125134/" target="_blank">https://git.reviewboard.kde.org/r/125134/</a>
</td>
</tr>
</tbody></table>
<br>
</span><blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px"><span class="">
<p style="margin-top:0">On September 10th, 2015, 12:39 p.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">I'm questioning the distribution of screenshots. Wouldn't it make more sense to generate it at runtime to show how it will look like (theme, proper dpi, etc.)?</p></pre>
</blockquote>
</span><span class=""><p>On September 10th, 2015, 12:48 p.m. CEST, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">i don't think it's feasible, it would have to load each single plasmoid in order to grab an image.
that means either screenshots are missing until the first time it's loaded or a very slow and expensive process is done the first time plasma starts (or each time a plasmoid is added)</p></pre>
</blockquote>
</span></blockquote>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">in that case we should start now thinking about we prevent that the screenshots are outdated like the preview videos of kwin effects.</p></pre><span class="HOEnZb"><font color="#888888">
<br>
<p>- Martin</p></font></span><span class="">
<br>
<p>On September 10th, 2015, 12:24 p.m. CEST, Marco Martin wrote:</p>
<table style="border:1px #888a85 solid;border-radius:6px" bgcolor="#fefadf" width="100%" cellpadding="12" cellspacing="0">
<tbody><tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color:grey"><i>Updated Sept. 10, 2015, 12:24 p.m.</i></p>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
plasma-workspace
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" width="100%" cellpadding="10" cellspacing="0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">As suggested by the VDG, add the possibility to have screenshots for plasmoids.
the widget explorer will be modified as well to show the screenshots in the applet list when available</p></pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp <span style="color:grey">(99e9add)</span></li>
<li>components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h <span style="color:grey">(f9cc89f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125134/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</span></div>
</div>
<br>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br>
<br></blockquote></div><br></div>