<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125135/">https://git.reviewboard.kde.org/r/125135/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 10th, 2015, 1:13 p.m. CEST, <b>andreas kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the thing is that it is not easy for the user to add or use an alternative plasmoid cause the plasmoids don't have specific application icons. now it is a mix between the user application icons, action icons, ....</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the VDG discuss to make for all widgets specific application icons. But first it is much work and second an preview would be much better cause the user will know what will be added. In addition the activity sidebar and the application switcher sidebar also have previews so we start talking about an global look and feel see user-prompt.com/look-and-feel-of-plasma-sidebars/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For the user previews would be the best way to show what the widget is used for. For the VDG it is less work to make screenshots than application icons and for the overall design it would be more consistent.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The problem that screenshots could be fast outdated is true but as long as the plasma theme don't change that much the widgets would have the same screenshot. In addition plasmoids from ghns have also screenshots to show the user what he will download. If there is no screenshot the app icon was shown.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">About the size. Now the list is quite long so it would be nice to have two columns and we prefere also to have two columns in addition the use can resize the panel to get an better overview.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is an rewrite for plasma mobile and I think we had a good solution for an consistant look and feel and should use it for the rewrite.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The problem that screenshots could be fast outdated is true but as long as the plasma theme don't change that much the widgets would have the same screenshot.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If we use history as a factor: it changes a lot. The plasma theme had tweaks to it in almost every release. We shouldn't just ignore that point.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not opposed to the feature, but I think we should think about the long term scalability of the feature. I'm in this situation now with kwin effects, which all got created just a month or two before breeze got started. So please consider this point as experience talking to you ;-)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For KWin I think the solution will be live preview: start a nested kwin which demonstrates the effect. Maybe something like that could also be done in this case. Instead of showing a screenshot, start plasmoidviewer in a dedicated mode to truly preview it (including interaction).</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On September 10th, 2015, 12:53 p.m. CEST, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and andreas kainz.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Sept. 10, 2015, 12:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As requested by the VDG, show screenshots in the widget explorer when available, to have a look similar to the activity manager (they'll do screenshots for all our plasmoids).
when a screenshot is not available, it falls back to the old design.
this is an in-between design, the latest design would be with two columns instead of one, but that would need to be tested as well beforehand, both in the widget explorer and the activity switcher</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktoppackage/contents/explorer/AppletDelegate.qml <span style="color: grey">(7ded06e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125135/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png">snapshot6.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>