<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124923/">https://git.reviewboard.kde.org/r/124923/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Sept. 9, 2015, 8:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 6e663a9e85cf8017fc20e0c749e5a2d939cef98c by Kai Uwe Broulik to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a rewrite of the old kolourpicker plasmoid, albeit a bit prettier.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Clicking the "drop" (it's color-picker, I would expect a pipette icon) enters picker mode, where you can click anywhere on the screen and have the color code (in a format you can configure) copied to your clipboard.
Clicking the color blob opens the history, showing the recentmost 9 colors (so it's a nice grid) which allow copying their respective color codes in various formats.
Activating the plasmoid (pressing the configured shortcut) will by default enter color picking mode, alternatively it brings up the popup like any other plasmoid.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">I have the impression that the color picker is off by one pixel horizontally (QRect weirdness? or our Breeze crosshair cursor?)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">I didn't test with multiple screens</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/CMakeLists.txt <span style="color: grey">(c60c350)</span></li>
<li>applets/colorpicker/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/colorpicker/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/colorpicker/package/contents/code/logic.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/colorpicker/package/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/colorpicker/package/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/colorpicker/package/contents/ui/configGeneral.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/colorpicker/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/colorpicker/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/colorpicker/plugin/colorpickerplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/colorpicker/plugin/colorpickerplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/colorpicker/plugin/grabwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/colorpicker/plugin/grabwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/colorpicker/plugin/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/kolourpicker/CMakeLists.txt <span style="color: grey">(522e0de)</span></li>
<li>applets/kolourpicker/Messages.sh <span style="color: grey">(072def0)</span></li>
<li>applets/kolourpicker/config-kolourpicker.h.cmake <span style="color: grey">(6cb43cc)</span></li>
<li>applets/kolourpicker/kolourpicker.h <span style="color: grey">(bde3ff7)</span></li>
<li>applets/kolourpicker/kolourpicker.cpp <span style="color: grey">(a4b0ea4)</span></li>
<li>applets/kolourpicker/plasma-kolourpicker-default.desktop <span style="color: grey">(4334ba1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124923/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/62f4f2df-c435-4676-a4c2-c359d89eaa7d__colorpickerpanel.png">In a panel</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/26b97307-2b19-4951-8b0c-fe26f960246b__colorpickerdesktop.png">On the desktop</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b9ecab53-8f40-49df-92da-f0e8479bd9a6__colorpickerhistory.png">History</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ab4720c0-e25c-486a-9f5a-3dbef5a25fa6__colorpickermenu.png">Formats menu</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/f051b3e9-28c3-4456-ae7a-9dad748519a9__colorpickersettings.png">Settings</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>